On Apr 20, 2010, at 7:32 AM, Kevan Miller wrote:
On Apr 20, 2010, at 2:40 AM, David Jencks wrote:
If you want to revert this , go ahead. I didn't intend to commit
it yet.
Put back in the decode for the reasons mentioned below.
However, this code is correct :-) The problem is that the URLs that
are coming in are invalid. I'm pretty sure that they are created
with file.toURL() which is deprecated because it is really broken.
You're supposed to use file.toURI().toURL() which will properly
encode the spaces.
We can, and should, definitely do that for all URLs we create from
files. Feel free to commit that change when you get a chance. Maybe
add a URLs.toURL(File) method just for symmetry purposes.
I attached a patch to OPENEJB-1252 to try to fix up all the file to
URL conversions but I haven't got a successful build yet.
Thanks for the info. I have no issues with code being correct. Just
don't like when it doesn't work... :-P
I gave the patch a try. Still seeing G deployment issues. StackTrace
is posted on the Jira.
Not sure about the given stack trace. At quick glance most of the G
22 code uses file.toURL() which will cause the issue.
Regardless, in most cases except for OpenEJB standalone, we don't
actually control the classloaders and the URLs that come out of them,
so definitely we need to be able to handle the improperly encoded URLs.
-David
