Thanks David! I've made those changes and got it checked in. Let me know if
there's any problems.

Jon

On Thu, May 20, 2010 at 11:08 PM, David Blevins <[email protected]>wrote:

>
> On May 20, 2010, at 2:53 PM, Jonathan Gallimore wrote:
>
> > I had a play with this - I've logged a JIRA here:
> > https://issues.apache.org/jira/browse/OPENEJB-1283 and attached a patch:
> >
> https://issues.apache.org/jira/secure/attachment/12445108/openejb-1283.diff
> >
> > This adds an openejb-tomcat-bundle module which downloads Tomcat,
> extracts
> > it, drops openejb.war in, runs the installer and zips everything back up
> > again.
> >
> > Any comments would be gratefully received!
> >
>
> Looks great!
>
> Maybe we can skip the step of copying the war and just extract it straight
> into the webapps dir.  Also, for sanity maybe we should include the
> "-${tomcat.version}" part in the zip we add to the local maven repo.
>
> -David
>
>

Reply via email to