Hi Ivan! Looks like a fantastic start!
One quick note, is that <around-timeout> is a list and @AroundTimeout can be used multiple times due to inheritance. What we can do is model the @AfterBegin, etc. after the @PostActivate type code. So we could process them in AnnotationDeployer.processCallbacks with @PostActivate, etc. In terms of validation we could move that into the CheckCallbacks class so it works for xml as well. Also we should update the ejb-jar.xml used in the JeeTest to have the new elements. Interceptors can have @AfterBegin as well, just like they can have @PostActivate, etc. as well. So we'll want to add that into InterceptorInfo and related. I love the static/final validation check. We should definitely incorporate that into the CheckCallbacks class. As we could greatly improve the CheckInvalidCallbacksTest to have invalid static/final and use some incorrect signatures and return types. I'll try and commit this patch and we can work on the above in a second iteration. Really great work in general! Very surprised how quick you got it all put together! -David On May 31, 2010, at 6:21 PM, Ivan wrote: > Hi, devs: > I attached a patch to OpenEJB-1147, it contains support for those new > session synchronization, please help to review it when you are available. > By the way, could anyone add me to the contribution list, so that I could > assign the JIRA to myself :-) > Thanks ! > > 2010/5/27 Ivan <[email protected]> > >> Hi devs : >> I hope to try to do some contributions to the OpenEJB project, I found >> a JIRA OPENEJB-1133, it seems to list some unimplemented functions for EJB >> 3.1. I hope that someone could show me some start points ? >> Thanks ! >> -- >> Ivan >> > > > > -- > Ivan
