Hi dev,

Can anyone help look at the patch ?   It's a blocker for geronimo 2.2.1
release.  Thanks in advance !

---------- Forwarded message ----------
From: Shawn Jiang (JIRA) <[email protected]>
Date: Tue, Jun 1, 2010 at 5:28 PM
Subject: [jira] Updated: (OPENEJB-1287) java.lang.NullPointerException:
null: null at
org.apache.openejb.assembler.classic.Assembler.createApplication
To: [email protected]



    [
https://issues.apache.org/jira/browse/OPENEJB-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]

Shawn Jiang updated OPENEJB-1287:
---------------------------------

   Attachment: OPENEJB-1287.patch

I can see following code

       if (accessTimeout.getUnit() == null)
accessTimeout.setUnit(TimeUnit.MILLISECONDS);

in StatelessInstanceManager.   Why not to make null unit fall back to
MILLISECONDS by default in Duration  ?


Attaching a patch for review.

> java.lang.NullPointerException: null: null at
org.apache.openejb.assembler.classic.Assembler.createApplication
>
--------------------------------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-1287
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1287
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 3.1.3
>         Environment: geronimo 22 branch + 3.1.3-snapshot
>            Reporter: Shawn Jiang
>         Attachments: OPENEJB-1287.patch
>
>
> I'm trying to add idleTimeout attribute to stateless container gbean in
geronimo 2.2 branch.  After checking fix for the JIRA
https://issues.apache.org/jira/browse/GERONIMO-5353, I got following
exception when starting the server.
> Caused by: org.apache.openejb.OpenEJBException: Error deploying
'ejb/mgmt/MEJB'. Exception: class java.lang.NullPointerException: null: null
> at
org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:602)
> ... 28 more
> Caused by: java.lang.NullPointerException
> at java.util.concurrent.TimeUnit$3.convert(TimeUnit.java:74)
> at org.apache.openejb.util.Duration.getTime(Duration.java:138)
> at org.apache.openejb.util.Pool$Builder.build(Pool.java:969)
> at
org.apache.openejb.core.stateless.StatelessInstanceManager.deploy(StatelessInstanceManager.java:408)
> at
org.apache.openejb.core.stateless.StatelessContainer.deploy(StatelessContainer.java:96)
> at
org.apache.openejb.assembler.classic.Assembler.createApplication(Assembler.java:599)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.




-- 
Shawn

Reply via email to