On Jun 2, 2010, at 3:23 PM, David Jencks wrote: > > On Jun 2, 2010, at 3:16 PM, David Blevins wrote: > >> Cool. Might see if I can rework it to a smaller change (primarily for >> patching and for merging to 3.1.x ease). With the AbstractFinder >> abstraction, seems like we don't need to abstract the entire >> AnnotationDeployer, just the part that creates the finder. > > Since you mentioned that there might be another way to do this, I realize it > would work at least as well to put the abstract methods in a FinderFactory > and inject it. Not sure if I'll get to changing it today && will be out till > probably monday..... go ahead if you think it's a good idea or if you have > another way to do this.
Took a shot at a factory that creates the finder. It basically always tries to use the OSGi approach whenever possible and falls back to the plain classpath scrape way if the app isn't a bundle. I put the BundleFinderFactory in a new osgi module that we'll need to use on the G-side. I didn't put it in the existing openejb-osgi module as that one has an Activator in it that I don't think G wants activated. I'm not a whiz at the manifest stuff so that part is still a todo. -David
