On Jul 15, 2010, at 5:42 PM, David Jencks wrote: > I'm taking a look at implementing the ejb 3.1 jndi support for > global/app/module contexts and binding ejbs in at standard names. I think it > might go pretty quickly since I already implemented a lot of this over in > geronimo.
Looks good, David. I wonder if we can put back in the part where App id is equal to the standalone module id. I assume this was done for the goofy portable EJB JNDI name syntax that cuts out part of the name if it is a standalone module vs in an ear. I was keenly aware at spec development time that that was directly against this: http://openejb.apache.org/3.0/jndi-names.html Which does not handle conditionally changing the format. Truth be told I'm not a terrible fan of dynamically changing the format of the portable name as someone on the external consuming side has no way to inquire if said EJB is in a standalone module or not and which format to use to look it up. Doing something as simple as writing a method that iterates over global JNDI listing all the EJBs suddenly becomes complicated as you have to deal with two different formats. Anyway, maybe for the purposes of the portable & shrinkable syntax, we can add a boolean to AppModule/AppInfo/AppContext that communicates that it is a generated module (i.e. wrapper for a standalone module). Maybe something like appInfo.generated=true. Thoughts? -David
