On Sep 30, 2010, at 10:56 AM, David Blevins wrote: > > On Sep 30, 2010, at 10:03 AM, [email protected] wrote: > >> Author: djencks >> Date: Thu Sep 30 17:03:07 2010 >> New Revision: 1003165 >> >> URL: http://svn.apache.org/viewvc?rev=1003165&view=rev >> Log: >> better data type >> >> Modified: >> >> openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/SessionConfig.java >> >> Modified: >> openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/SessionConfig.java >> URL: >> http://svn.apache.org/viewvc/openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/SessionConfig.java?rev=1003165&r1=1003164&r2=1003165&view=diff >> ============================================================================== >> --- >> openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/SessionConfig.java >> (original) >> +++ >> openejb/trunk/openejb3/container/openejb-jee/src/main/java/org/apache/openejb/jee/SessionConfig.java >> Thu Sep 30 17:03:07 2010 >> @@ -64,7 +64,7 @@ import java.util.List; >> public class SessionConfig { >> >> @XmlElement(name = "session-timeout") >> - protected BigInteger sessionTimeout; >> + protected Integer sessionTimeout; >> @XmlElement(name = "cookie-config") >> protected CookieConfig cookieConfig; >> @XmlElement(name = "tracking-mode") >> @@ -75,11 +75,11 @@ public class SessionConfig { >> @XmlSchemaType(name = "ID") >> protected java.lang.String id; >> >> - public BigInteger getSessionTimeout() { >> + public Integer getSessionTimeout() { >> return sessionTimeout; >> } >> >> - public void setSessionTimeout(BigInteger value) { >> + public void setSessionTimeout(Integer value) { >> this.sessionTimeout = value; >> } > > I wonder if maybe Long isn't the right type?
By the time it gets consumed its an int. (jetty uses seconds, and an int). The time unit is minutes, so I don't think even a short would be maxed out by any meaningfully usable value. Do you think a larger than int-max value makes any sense? thanks david jencks > > > -David >
