On Oct 6, 2010, at 8:44 AM, Jean-Louis MONTEIRO wrote:

> 
> Hi,
> 
> I've been requested for such a feature for weeks.
> We have include/exclude mechanisms for standalone mode but we don't have
> anything yet in Tomcat.
> 
> I'd like to give it a try.
> IMHO, we can patch TomcatWebappBuilder in order to delegate things to
> DeplymentResolver.
> To get include/exclude values per webapp, we can use parameters in
> context.xml.

That could work.  I can't remember the order of things in terms of if that file 
is read in and available when we actually do scanning.

On a related note, I've been thinking for a while that perhaps we went with the 
least obvious technique for limiting scan scope (paths) and should probably add 
packages as an option.  So in addition to:

  openejb.deployments.classpath.include
  openejb.deployments.classpath.exclude

We could also have:

  openejb.deployments.package.include
  openejb.deployments.package.exclude

Not sure if we would want 'package' or 'packages', but we could support both 
for those who can never remember such minor detail (like me :)

That would require a minor change to xbean-finder so that we can supply a 
little java.io.FileFilter style of filtering class files that are read.

In terms of precedence, it's probably easiest to apply the classpath 
include/excludes as we do now, then do package includes/excludes on the 
remaining jars.

Thoughts?


-David

Reply via email to