On Oct 31, 2010, at 10:49 PM, David Jencks wrote:

> 
> On Oct 31, 2010, at 5:46 PM, David Blevins wrote:
> 
>> 
>> On Oct 30, 2010, at 11:41 PM, [email protected] wrote:
>> 
>>> Author: djencks
>>> Date: Sun Oct 31 06:41:46 2010
>>> New Revision: 1029263
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1029263&view=rev
>>> Log:
>>> OPENEJB-1382 Put the xml configurer back in, it's needed to determine 
>>> active decorators.
>> 
>> We were already handing it the list of decorators from the beans.xml via the 
>> Beans JAXB tree.
>> 
>> Any details on what was not working there?  Ideally we would just fix that.
> 
> Nothing was marking the decorators mentioned in beans.xml as enabled in owb.  
> I didn't see the openejb code that looks at beans.xml.  Does openejb need to 
> know what's in beans.xml other than what owb needs?

I found the code you are thinking of in CdiScanner.  At the moment in 
geronimo-openejb we're using an Osgi scanner that finds all classes just like 
the owb scanners do.  Thus, your code that registers the decorators wasn't 
getting called.    So, I agree we need a better solution.

Have we demonstrated unequivocally that owb can work fine without all the 
classes, just the ones cdiscanner finds?

thanks
david jencks

> 
> thanks
> david jencks
> 
>> 
>> 
>> -David
>> 
> 

Reply via email to