I've just pushed a patch for this in JIRA issue #OPENEJB-1527

-Thibaut
________________________________________
De : Robert Thibaut
Date d'envoi : mardi 19 avril 2011 19:53
À : [email protected]
Objet : RE : bug in em.find()

Thanks for the fix! Looking more in depth into the class, I see other problems 
in JPA 2.0 methods.

- In the following methods:
    public void lock(Object entity, LockModeType lockMode, Map<String, Object> 
properties) {
    public void refresh(Object entity, LockModeType lockMode, Map<String, 
Object> properties) {
    public void refresh(Object entity, LockModeType lockMode) {
    public void refresh(Object entity, Map<String, Object> properties) {
entityManager is used in place of entity.

- Transaction management is not always  correct (or at least not consistent 
with JPA1 methods)
e.g. refresh methods does not assume an active transaction.

- Less important, timing measurement is  implemented JPA 1 methods but not JPA2.

I should be able to provide a patch for this by tomorrow.

Thibaut
________________________________________
De : Robert Thibaut
Date d'envoi : mardi 19 avril 2011 16:22
À : [email protected]
Objet : bug in em.find()

Hello there,

I think there is an error in JtaEntityManager class,in 2 find methods:

    public <T> T find(Class<T> entityClass, Object primaryKey, LockModeType 
lockMode) {
    public <T> T find(Class<T> entityClass, Object primaryKey, LockModeType 
lockMode, Map<String, Object> properties) {

when calling the delegate, entityManager is used in place of the primaryKey.

giving this exception at runtime:

Caused by: java.lang.ClassCastException: 
org.apache.openjpa.persistence.EntityManagerImpl cannot be cast to 
java.lang.Number
        at 
org.apache.openjpa.util.ApplicationIds.fromPKValues(ApplicationIds.java:179)
        at 
org.apache.openjpa.kernel.BrokerImpl.newObjectId(BrokerImpl.java:1267)


 (3.2.-x branch and trunk)

Regards,
Thibaut Robert


Ce message et les pièces jointes sont confidentiels et réservés à l'usage 
exclusif de ses destinataires. Il peut également être protégé par le secret 
professionnel. Si vous recevez ce message par erreur, merci d'en avertir 
immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant 
être assurée sur Internet, la responsabilité du groupe Atos Origin ne pourra 
être recherchée quant au contenu de ce message. Bien que les meilleurs efforts 
soient faits pour maintenir cette transmission exempte de tout virus, 
l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne 
saurait être recherchée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for 
the addressee; it may also be privileged. If you receive this e-mail in error, 
please notify the sender immediately and destroy it. As its integrity cannot be 
secured on the Internet, the Atos Origin group liability cannot be triggered 
for the message content. Although the sender endeavours to maintain a computer 
virus-free network, the sender does not warrant that this transmission is 
virus-free and will not be liable for any damages resulting from any virus 
transmitted.

Reply via email to