Thanks! I quite like the way it runs embedded. I've tried to make it require as little as possible in the classpath, so currently the catalina jar is needed, but OpenEJB is picked up by deploying the openejb.war file.
The first commit was a bit hacky, as it tried to pick up the openejb.war from the classpath, the idea being that you could just chuck the war on your classpath, and it would be picked up automatically. It doesn't seem to play nicely with Maven though, so although it worked on my machine at the time, it didn't when I tranferred everything over to my new work machine. Now, by default it looks for the war file on the file system, and Maven could be used to download it. I feel this could be better still though, with the adapter perhaps doing a download automatically if the war file isn't available rather than relying on the build system to provide it - the idea is to "skip the build" and test against as many containers as possible without the developer having to do too much extra work. I was thinking of perhaps making the Arquillian developers aware of this adapter - any thoughts or objections to that? Maybe they would have some thoughts or suggestions? Jon On Fri, May 27, 2011 at 7:32 PM, David Blevins <[email protected]>wrote: > > On May 21, 2011, at 1:36 PM, Jonathan Gallimore wrote: > > > I hacked up a quick Arquillian adaptor for TomEE which I'm using for a > > project at work. Its a bit raw, but I've checked it into the sandbox > area. > > If you fancy checking it out, any feedback would be welcome! > > Cool, looks like it boots TomEE embedded! > > Looks pretty good to me. What is raw about it? > > > -David > >
