1) isn't it fixed on the repo? (trunk + 3.2 branch)
2) i'm not opposed to it ;)

- Romain

2011/7/6 mclu <[email protected]>

> Hi.
>
> While trying to delegate logging to our internal logger while using OpenEJB
> the embedded way I saw 2 "issues" in the code of 3.1.4
>
> 1. Issue:
> At ReadDescriptors.java
> there is a System out that should be replaced by normal logging:
>
> System.out.println("FOO moduleName = " + moduleName);
>
> 2. Issue:
> Inside org.apache.openejb.ObenEJB.java
> I found the setting "openejb.nobanner" to prevent the version info to
> System.out.
> I found it misunderstanding that if I set nobanner to true, it is
> displayed.
> true is also the default if not set.
> Maybe this should be replaced by the behavior which you can see on other
> places like:
>  boolean display = System.getProperty("openejb.nobanner") == null;
>
> Do you agree?
>
> Markus Lutum
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/2-Issued-with-logging-tp3648299p3648299.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Reply via email to