On Sep 28, 2011, at 3:36 PM, Jonathan Gallimore wrote: > When I hacked up the Remote with zip adapter I intended to > merge it into the remote adapter - along the lines of: check to see if TomEE > is running on the port specified in arquillian.xml. If it is, just deploy > straight to it. If not, go grab the zip and use that. Does that sound like a > reasonable idea?
Very reasonable. That's what the itests have done for years, the CDI TCK does and the Java EE TCK setup does. It's pretty easy to have the rule of "if you don't want us to start a server, make sure a server is started" > That leaves the embedded-with-war adapter as something that might seem a bit > odd. Currently I can't get it to run correctly, but that might be something > wrong with my machine. What's people's opinion of this method? Should we > drop this, or is it a useful adapter to hang on to? My impression is I would never ever advise a user to use it. That said, it's an absolutely fabulous way for us to test the drop-in-war functionality. Well, almost fabulous... the real world scenario is an existing Tomcat install, not an embedded one. Either way, if we say to people "you can do this and it works!" having an adapter for it us a must. Especially if we get things to the point where we can easily reuse the full set of tests on each adapter. At that point we just need to hook up each adapter with a buildbot builder and suddenly we have a dreamlike level of testing for the various features we offer. This "Tomcat + war" approach is a great way to setup buildbot to test "Tomcat 5.5 + war" and "Tomcat 6 + war" It's hard to describe how important this stuff is. Once it's in place, we won't be able to imagine life before it. :) -David
