Looks great to me. Here is my +1.
Jean-Louis 2011/10/3 Romain Manni-Bucau <[email protected]> > +1 > > - Romain > > 2011/10/3 Romain Manni-Bucau <[email protected]> > > > about terracotta we shouldn't exclude it by default since it will not > work > > at runtime with default configuration. Maybe we can decrease maven > timeout.. > > > > - Romain > > > > > > 2011/10/3 David Jencks <[email protected]> > > > >> +1 > >> > >> I downloaded and built the source-release. It looks ok to me! > >> > >> A couple minor notes: > >> > >> - At least one artifact, > >> > http://repo.terracotta.org/maven2/net/sf/ehcache/ehcache-terracotta/2.4.3/ehcache-terracotta-2.4.3.jar > , > >> was really hard to locate. It's pulled in as part of the hibernate > support. > >> I doubt it's needed so figuring out what it's a dependency of and > excluding > >> it might be good. Otherwise listing the repo in the repositories list > might > >> be ok. I realize this is more a maven defect than an openejb one but > fixing > >> maven isn't going to happen soon. > >> > >> - the apache-tomcat in the openejb svn repo is copied from the tomcat > >> distro site, but that wasn't too obvious to me. It might be nice to put > a > >> comment to that effect in the associated pom (and add an apache license > >> header since it will no longer be generated). > >> > >> This was a really great effort and the final result includes a really > nice > >> build :-) > >> > >> congratulations everyone. > >> > >> david jencks > >> > >> On Oct 2, 2011, at 6:28 PM, David Blevins wrote: > >> > >> > NOTE TO EVERYONE > >> > > >> > I know re-rolling can be very time consuming and often > >> > people vote on the first release attempt and never vote > >> > again. We want a strong turnout for this vote and it > >> > would be a shame to end it with 3, 4 or 5 votes. > >> > > >> > In an effort to save everyone a considerable amount of > >> > time, I have used rsync to compare the entire set of > >> > unpacked 019 and 024 binaries. See the output at the > >> > bottom of this email. > >> > > >> > PLEASE DO REVOTE. If you liked the previous set of > >> > binaries and trust rsync, it should only take 5 minutes to > >> > see that things are still good and revote. > >> > > >> > You can also run any comparisons you like on my directory > >> > in people. The files/directories are read-only so you can > >> > feel free to run commands without accidentally messing up > >> > something. > >> > > >> > - - - - - - - - - - - - - - - - - - - - - - - - - - > >> > > >> > Changes since last vote: > >> > - Added missing W3C and CDDL license/noticed information to > openejb-jee > >> and the source-release.zip > >> > > >> > > >> > https://repository.apache.org/content/repositories/orgapacheopenejb-023/ > >> > > >> > Src: > >> > > >> > org/apache/openejb/openejb/4.0.0-beta-1/openejb-4.0.0-beta-1-source-release.zip > >> > > >> > Bin: > >> > > >> > org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-plus.tar.gz > >> > > >> > org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-plus.zip > >> > > >> > org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-webprofile.tar.gz > >> > > >> > org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-webprofile.zip > >> > > >> > org/apache/openejb/examples/4.0.0-beta-1/examples-4.0.0-beta-1-src.tar.gz > >> > > org/apache/openejb/examples/4.0.0-beta-1/examples-4.0.0-beta-1-src.zip > >> > org/apache/openejb/javaee-api/6.0-2/javaee-api-6.0-2.zip > >> > > >> > org/apache/openejb/openejb-standalone/4.0.0-beta-1/openejb-standalone-4.0.0-beta-1.tar.gz > >> > > >> > org/apache/openejb/openejb-standalone/4.0.0-beta-1/openejb-standalone-4.0.0-beta-1.zip > >> > > >> > org/apache/openejb/openejb-tomcat-plus-webapp/4.0.0-beta-1/openejb-tomcat-plus-webapp-4.0.0-beta-1.war > >> > > >> > org/apache/openejb/openejb-tomcat-webapp/4.0.0-beta-1/openejb-tomcat-webapp-4.0.0-beta-1.war > >> > > >> > Tag: > >> > > >> > http://svn.apache.org/repos/asf/openejb/tags/openejb-4.0.0-beta-1/ > >> > > >> > Report: > >> > > >> > > http://people.apache.org/~dblevins//orgapacheopenejb-024/archives.html > >> > > >> > > >> > Here's my +1 > >> > > >> > > >> > -David > >> > > >> > > >> > dblevins@minotaur:~/public_html$ rsync -v -p -r --size-only --dry-run > >> orgapacheopenejb-019/content orgapacheopenejb-023/ | grep -v 'jar$' > >> > sending incremental file list > >> > > >> > content/org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-plus.zip.contents/apache-tomee-plus-1.0.0-beta-1/webapps/openejb/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-plus.zip.contents/apache-tomee-plus-1.0.0-beta-1/webapps/openejb/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-webprofile.zip.contents/apache-tomee-webprofile-1.0.0-beta-1/webapps/openejb/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/apache-tomee/1.0.0-beta-1/apache-tomee-1.0.0-beta-1-webprofile.zip.contents/apache-tomee-webprofile-1.0.0-beta-1/webapps/openejb/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/openejb-jee/4.0.0-beta-1/openejb-jee-4.0.0-beta-1-javadoc.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/openejb-jee/4.0.0-beta-1/openejb-jee-4.0.0-beta-1-javadoc.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/openejb-jee/4.0.0-beta-1/openejb-jee-4.0.0-beta-1-sources.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/openejb-jee/4.0.0-beta-1/openejb-jee-4.0.0-beta-1-sources.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/openejb-jee/4.0.0-beta-1/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/openejb-jee/4.0.0-beta-1/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/openejb-standalone/4.0.0-beta-1/openejb-standalone-4.0.0-beta-1.zip.contents/apache-openejb-4.0.0-beta-1/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/openejb-standalone/4.0.0-beta-1/openejb-standalone-4.0.0-beta-1.zip.contents/apache-openejb-4.0.0-beta-1/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/openejb-tomcat-plus-webapp/4.0.0-beta-1/openejb-tomcat-plus-webapp-4.0.0-beta-1.war.contents/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/openejb-tomcat-plus-webapp/4.0.0-beta-1/openejb-tomcat-plus-webapp-4.0.0-beta-1.war.contents/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/openejb-tomcat-webapp/4.0.0-beta-1/openejb-tomcat-webapp-4.0.0-beta-1.war.contents/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/LICENSE > >> > > >> > content/org/apache/openejb/openejb-tomcat-webapp/4.0.0-beta-1/openejb-tomcat-webapp-4.0.0-beta-1.war.contents/lib/openejb-jee-4.0.0-beta-1.jar.contents/META-INF/NOTICE > >> > > >> > content/org/apache/openejb/openejb/4.0.0-beta-1/openejb-4.0.0-beta-1-source-release.zip.contents/openejb-4.0.0-beta-1/LICENSE > >> > > >> > content/org/apache/openejb/openejb/4.0.0-beta-1/openejb-4.0.0-beta-1-source-release.zip.contents/openejb-4.0.0-beta-1/NOTICE > >> > > >> > sent 4777396 bytes received 18473 bytes 504828.32 bytes/sec > >> > total size is 833184323 speedup is 173.73 (DRY RUN) > >> > > >> > >> > > >
