On Jun 5, 2012, at 5:59 AM, Thiago Veronezi wrote:
> I like it!
> What do you think about this mockup?
> https://dl.dropbox.com/u/1459144/tomee_apps.png
That's a good start. We could get a bit fancier if we use the DeployerEjb. If
there is a validation issue and the deployment fails the caller will get a
ValidationFailedException which contains all the details on each issue.
private final ValidationError[] errors;
private final ValidationFailure[] failures;
private final ValidationWarning[] warnings;
On each ValidationException you can call `public String getMessage(int level)`.
The stuff we see in the logs is on level 2 by default. That's basically
designed to be a one line error message. The stuff on level 3 is multi-line
text.
We could send all that information (message levels 2 and 3, the key and
details) back to the caller (the web GUI) just like you do now and include some
information about each failure and use it to create a nice rich looking view of
the failures.
There would be some kind of table listing each failure showing the key and
summary (message level 2). Clicking the row would expand that entry out to
show the multi-line message level 3.
If it works out we might even add more data to the validation exceptions like
spec references or documentation links.
Log messages are great, but you have to loose a lot of data for them to be
readable. This validation stuff has probably been waiting for someone to come
along and slap a nice UI on it :)
It could really set this feature on fire!
-David
> On Tue, Jun 5, 2012 at 12:59 AM, David Blevins <[email protected]>wrote:
>
>> In light of the recent validation failure on deployment, there's a clear
>> feature we've been needing that would be great to add.
>>
>> The console should be able to deploy apps. When there are validation
>> failures/warnings those would be listed in nice yellow and red boxes that
>> are clickable. When clicked, they would expand downward and show the
>> verbose validation text.
>>
>> All our validation comes in three output levels. The third is email-like
>> and sometimes even includes code snippets using the user's own method or
>> class names. We could maybe even start using markdown formatting of that
>> so the code snippets could be rendered nicely.
>>
>> Thoughts?
>>
>>
>> -David
>>
>>
>>
>>
