On Wed, Jul 07, 2004 at 01:02:40AM +0200, Jacek Laskowski wrote: > Jacek Laskowski wrote: > > >and here's what they broke and where *you* can help: > > > >2/ logging (log4j) doesn't work > > Now, it works fine, either you define log4j.configuration property or > leave it to be set as configured in conf/default.logging.conf file. > > One more thing that asks for improvements - WebAdmin. There're a few > places where a JSP looks for OpenEJB configuration via > System.getProperty instead of OpenEJB.getProperty.
I read the changes on the plane yesterday (back in SF again) and have to commend you for all the crap you had to deal with in regards to system property usage. I always knew it would be a bear to deal with, hats off to you for surviving. I was never happy with the implicit relationship between the ConfigUtils class and the implementations of the Loader interface in org.openejb.loader. When you add properties into the picture it gets unbearable pretty quick. A perfect example of implicitly linked code that has become unmanageably tightly-coupled because the relationships between them are masked through indirection. In short, bad code getting worse. It's clear we need to more explicitly hook them together into something like LoaderProfiles or whatever that contain ClassLoader, Properties, and the embedding chain as it relates to the different ways you can embed and load OpenEJB. Still going through permutations in the back of my mind--haven't locked into the right answer yet, but know I'm on the right track. -David
