On 7/27/07, Craig L Russell <[EMAIL PROTECTED]> wrote: > > > The other thing is the committer should do a diff before commit. If > the diff looks bad (like this one) then the committer should fix it > before committing the change.
I agree. We've run into this in the past (I was the culprit at that time). Verifying the diff (patch) before committing should be a standard practice to avoid these type of commits. FYI, if you are using Eclipse, I have found that it's best to uncheck the "Ignore white space" box on the Compare/Patch Preference panel. This will show these type of "bad patches" before committing so that you can correct the problem first. Thanks, Kevin Craig > > On Jul 27, 2007, at 11:01 AM, Patrick Linskey wrote: > > > Hi, > > > > These types of commits are really difficult to parse -- I find it hard > > to believe that we really needed to change every line of the file. > > Does anyone know of any way to put in place some sort of line-ending > > restrictions, or otherwise avoid these sorts of commits? > > > > -Patrick > > > > On 7/27/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > >> > >> Modified: openjpa/trunk/openjpa-project/src/doc/manual/ > >> ref_guide_mapping.xml > >> URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-project/ > >> src/doc/manual/ref_guide_mapping.xml? > >> view=diff&rev=560330&r1=560329&r2=560330 > >> ===================================================================== > >> ========= > >> --- openjpa/trunk/openjpa-project/src/doc/manual/ > >> ref_guide_mapping.xml (original) > >> +++ openjpa/trunk/openjpa-project/src/doc/manual/ > >> ref_guide_mapping.xml Fri Jul 27 10:38:24 2007 > >> @@ -1,3032 +1,3328 @@ > >> -<?xml version="1.0" encoding="UTF-8"?> > >> -<!-- > >> - Licensed to the Apache Software Foundation (ASF) under one > >> - or more contributor license agreements. See the NOTICE file > >> - distributed with this work for additional information > >> - regarding copyright ownership. The ASF licenses this file > >> - to you under the Apache License, Version 2.0 (the > >> - "License"); you may not use this file except in compliance > >> - with the License. You may obtain a copy of the License at > >> - > >> - http://www.apache.org/licenses/LICENSE-2.0 > >> - > >> - U > > Craig Russell > Architect, Sun Java Enterprise System http://java.sun.com/products/jdo > 408 276-5638 mailto:[EMAIL PROTECTED] > P.S. A good JDO? O, Gasp! > > >
