Hi Craig,
My suggestion was to add a serial version number to the patch,
irrespective of authorship.
1. Author A submits first patch: OPENJPA-123.1.patch
2. Author A updates the patch : OPENJPA-123.2.patch
3. Author B comes up with an alternative patch: OPENJPA-123.3.patch
Pinaki Poddar
972.834.2865
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Saturday, August 11, 2007 11:29 AM
To: [email protected]
Subject: Re: Names of patches for jira issues
Hi Pinaki,
On Aug 10, 2007, at 5:47 PM, Pinaki Poddar wrote:
+1
A small addition to Craig's proposed convention:
ppenjpa-xxx.z.patch or openjpa-xxx.z.txt where xxx is the JIRA issue
number and z is the patch number as often there are multiple
versions
of the patch on the same issue.
I like this idea. Elaborating, if the patch is updated by the author,
the same name should be used, e.g. openjpa-158.patch is the first
patch.
If the patch is updated, openjpa-158.patch replaces the original.
Jira
knows to make available for download only the latest version of a
patch
with the same name.
If another patch is added, to cover some additional cases,if the
original patch is committed, or if someone else has a different
view of
the fix, then openjpa-158.2.patch, openjpa-158.3.patch, and
openjpa-158.4.patch could be used.
Is that what you had in mind?
Craig
Pinaki Poddar
972.834.2865
-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Friday, August 10, 2007 7:07 PM
To: [email protected]
Subject: Names of patches for jira issues
I'd like to propose an informal convention for jira patch
attachments.
1. Use the name of the jira in the patch file name, and use either a
.txt or .patch suffix.
2. Do the svn diff >openjpa-249.patch from trunk.
These small things make it easier when downloading the patch to know
where it applies and you don't have to rename the patch to remember
which issue it applies to.
Obviously, no one will complain about details like this when getting
patches "free as in work" but it might make it a bit easier to
verify
them.
What do you all think?
Craig
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/
products/jdo
408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!
Notice: This email message, together with any attachments, may
contain information of BEA Systems, Inc., its subsidiaries
and affiliated entities, that may be confidential, proprietary,
copyrighted and/or legally privileged, and is intended solely
for the
use of the individual or entity named in this message. If you are
not
the intended recipient, and have received this message in error,
please immediately return this by email and then delete it.
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/
jdo
408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!
Notice: This email message, together with any attachments, may
contain information of BEA Systems, Inc., its subsidiaries
and affiliated entities, that may be confidential,
proprietary, copyrighted and/or legally privileged, and is
intended solely for the use of the individual or entity named in
this message. If you are not the intended recipient, and have
received this message in error, please immediately return this by
email and then delete it.
