[
https://issues.apache.org/jira/browse/OPENJPA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528633
]
Patrick Linskey commented on OPENJPA-305:
-----------------------------------------
Generally, it looks good. Some comments:
I don't understand why we do the isDynamic() check in equals() and hashCode(),
though; shouldn't getOriginalValue() always be correct?
Also, it looks like there's a synchronization issue at hand -- based on my
reading, dynamic sets must occur in a synchronized manner, or the behavior is
non-deterministic. That is OK (I don't think that we necessarily want to add
synchronization on accesses), but should be well-documented.
> Dynamic configuration of EntityManagerFactory
> ---------------------------------------------
>
> Key: OPENJPA-305
> URL: https://issues.apache.org/jira/browse/OPENJPA-305
> Project: OpenJPA
> Issue Type: New Feature
> Reporter: Pinaki Poddar
> Attachments: openjpa-305.patch.1.txt
>
>
> OpenJPA configures EntityManagerFactory at creation time via an instance of
> Configuartion object. Once EntityManagerFactory is created and a
> EntityManager is issued from it -- the Configuration is frozen by design.
> That is no further changes to Configuration is allowed as long as
> EntityManagerFactory lives.
> For certain configuration properties, it is desirable to change them during
> the lifetime of a EntityManagerFactory.
> This issue is raised to initiate a discussion on such a feature, the
> possibility and limitations of dynamic update and track the impact of such a
> change as frozen Configuration is an important assumption.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
