[ 
https://issues.apache.org/jira/browse/OPENJPA-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534409
 ] 

Teresa Kan commented on OPENJPA-399:
------------------------------------

Kevin,
Thanks for the comments. I fixed the code based on your comments. However, I 
can't determine the configuration error because I can't tell whether the null 
schema is valid or not. 

For the question about HashMap, yes, HashMap can handle the null key . Here is 
the info from java doc:
"Hash table based implementation of the Map interface. This implementation 
provides all of the optional map operations, and permits null values and the 
null key"

For the last question about the logic in SchemaGroup.findTable and 
findSequence. It is not necessary to combine them together since they have 
different return object. Instead of adding more checking in a common method, 
the current way may be ok..



> openjpa did not handle multiple schema names with same table name
> -----------------------------------------------------------------
>
>                 Key: OPENJPA-399
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-399
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 1.0.1
>         Environment: JDK1.5, OPENJPA verison 580425
>            Reporter: Teresa Kan
>            Assignee: Teresa Kan
>         Attachments: OPENJPA_399.patch, OPENJPA_399_2.patch, 
> TestMultipleSchemaNames.zip
>
>
> Two entities have the same table name but with different schema, only one 
> table is created. In addition, when two entities use the generatedType.AUTO 
> for ID, only one OPENJPA_SEQUENCE-TABLE is created.
> The problem due to the SchemaGroup.findTable() which only looked for a table 
> name from all the schemas. Once the table was found in one of the schema then 
> it exited and assumed that the table existed. Same problem in the 
> TableJDBCSeq.addSchema().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to