DBDictionary.java

David Ezzio Wed, 30 Jan 2008 11:59:47 -0800

Hi Marc,

Repeated cleans did not help, but blowing away the derby entries in theMaven repository and the OpenJPA entry, then running install did help.It's happy now.


Thanks,

David

Marc Prud'hommeaux wrote:

David-

It passed for me as well. If you first run "mvn clean", do the test pass?


On Jan 30, 2008, at 10:57 AM, Patrick Linskey wrote:
I'm not; it passed the remote checkin tests on my TeamCity machine.

-Patrick

On Jan 30, 2008 9:46 AM, David Ezzio <[EMAIL PROTECTED]> wrote:
Hi,

With this change, I'm picking up a test failure shown below.  Anyone
else seeing this?

David Ezzio

0  test  INFO   [main] openjpa.jdbc.JDBC - Using dictionary class
"org.apache.openjpa.jdbc.sql.DerbyDictionary"
   (Apache Derby 10.2.2.0 - (485682) ,Apache Derby Embedded JDBC Driver
10.2.2.0 - (485682)).
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.031
sec <<< FAILURE!
testVersionTimestamp(org.apache.openjpa.persistence.jdbc.annotations.TestVersion)
 Time elapsed: 0.11 sec  <<< FAILURE!
junit.framework.AssertionFailedError
   at junit.framework.Assert.fail(Assert.java:47)
   at junit.framework.Assert.assertTrue(Assert.java:20)
   at junit.framework.Assert.assertTrue(Assert.java:27)
   at
org.apache.openjpa.persistence.jdbc.annotations.TestVersion.testVersionTimestamp(TestVersion.java:110)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:585)
   at junit.framework.TestCase.runTest(TestCase.java:154)
   at junit.framework.TestCase.runBare(TestCase.java:127)
   at junit.framework.TestResult$1.protect(TestResult.java:106)
   at junit.framework.TestResult.runProtected(TestResult.java:124)
   at junit.framework.TestResult.run(TestResult.java:109)
   at junit.framework.TestCase.run(TestCase.java:118)
   at
org.apache.openjpa.persistence.test.PersistenceTestCase.run(PersistenceTestCase.java:122)
   at junit.framework.TestSuite.runTest(TestSuite.java:208)
   at junit.framework.TestSuite.run(TestSuite.java:203)
   at sun.reflect.GeneratedMethodAccessor101.invoke(Unknown Source)
   at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:585)
   at
org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:210)
   at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:135)
   at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:122)
   at org.apache.maven.surefire.Surefire.run(Surefire.java:129)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
   at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
   at java.lang.reflect.Method.invoke(Method.java:585)
   at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:225)
   at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:747)
[EMAIL PROTECTED] wrote:
Author: pcl
Date: Tue Jan 29 22:49:26 2008
New Revision: 616658

URL: http://svn.apache.org/viewvc?rev=616658&view=rev
Log:
OPENJPA-505. Committing on behalf of [EMAIL PROTECTED] (Joe Weinstein).

Modified:
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java
Modified:openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.javaURL:http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java?rev=616658&r1=616657&r2=616658&view=diff==============================================================================---openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java(original)+++openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.javaTue Jan 29 22:49:26 2008
@@ -1660,8 +1660,13 @@
     */
    protected String insertSize(String typeName, String size) {
     if(StringUtils.isEmpty(size)) {
-             return typeName;
-     }
+
+          int idx = typeName.indexOf("{0}");
+          if (idx != -1) {
+            return typeName.substring(0,idx);
+       }
+       return typeName;
+             }

        int idx = typeName.indexOf("{0}");
        if (idx != -1) {
--
Patrick Linskey
202 669 5907

Re: svn commit: r616658 - /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/DBDictionary.java

Reply via email to