You might be right. I think that would help with OPENJPA-430 as well. The problem I'm running into happens when we resolve the mappings for the same field more than once. The first time we generate the column name (ex: ID) and populate our internal table structure correctly. The next time we go through the mapping we detect that there already is a column named ID and generate a new unique name ID1.
What's weird is that none of our unit tests hit the problem and it only happens to one Entity in the test bucket. -Mike On Wed, Mar 5, 2008 at 5:23 PM, Patrick Linskey <[EMAIL PROTECTED]> wrote: > If we're going to invest time in this arena, I think it'd be better to > just look into changing our algorithms to properly escape reserved > words. > > -Patrick > > On Sun, Mar 2, 2008 at 1:30 PM, Michael Dick (JIRA) <[EMAIL PROTECTED]> > wrote: > > > > [ > https://issues.apache.org/jira/browse/OPENJPA-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > > > Michael Dick reassigned OPENJPA-528: > > ------------------------------------ > > > > Assignee: Michael Dick > > > > > FK columns which contain reserved workds are renamed incorrectly. > > > ----------------------------------------------------------------- > > > > > > Key: OPENJPA-528 > > > URL: > https://issues.apache.org/jira/browse/OPENJPA-528 > > > Project: OpenJPA > > > Issue Type: Bug > > > Reporter: Michael Dick > > > Assignee: Michael Dick > > > > > > The check for reserved words in FK column names happens before we > append the _ID suffixes. As a result if a reserved word is found we end up > appending a number to the reserved word and then appending _ID. > > > Whats worse is that the check for uniqueness also occurs before we > append the _ID, which could lead to other problems down the road. > > > > -- > > This message is automatically generated by JIRA. > > - > > You can reply to this email to add a comment to the issue online. > > > > > > > > -- > Patrick Linskey > 202 669 5907 >
