Re: svn commit: r676604 - /openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/StateManagerImpl.java

[Patrick Linskey]

Hi,

It looks like this checkin broke some tests.

In related news, http://openjpa-teamcity.dyndns.org:8111 is back up, but I need to recreate accounts for those who are interested in them. So, if you want one, let me know.

-Patrick

On Jul 14, 2008, at 7:34 AM, [EMAIL PROTECTED] wrote:

Author: ppoddar
Date: Mon Jul 14 07:33:59 2008
New Revision: 676604

URL: http://svn.apache.org/viewvc?rev=676604&view=rev
Log:
Skip dirty check for nontransactional, runtime-enhanced instances

Modified:



URL: 
http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/StateManagerImpl.java?rev=676604&r1=676603&r2=676604&view=diff

@@ -811,7 +811,7 @@
    public void dirtyCheck() {
        if (!needsDirtyCheck())
            return;
-
+
        SaveFieldManager saved = getSaveFieldManager();
        if (saved == null)
            throw new InternalException(_loc.get("no-saved-fields",
@@ -837,6 +837,8 @@
            return false;
        if (isNew() && !isFlushed())
            return false;
+        if (!isTransactional())
+            return false;
        return true;
    }

openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/ kernel/StateManagerImpl.java Modified: openjpa/trunk/openjpa-kernel/src/main/java/org/apache/ openjpa/kernel/StateManagerImpl.java = = = = = = = = ====================================================================== --- openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/ kernel/StateManagerImpl.java (original) +++ openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/ kernel/StateManagerImpl.java Mon Jul 14 07:33:59 2008

--
Patrick Linskey
202 669 5907

smime.p7s
Description: S/MIME cryptographic signature