Hi Pinaki,

This is a very signficant change and it essentially replaces the former
QuerySQLCache.  Your design looks very solid and fairly nonintrusive - which
is a major feat considering the complexity of this undertaking.

I reviewed the JIRA and expected to see some performance measurements
showing the gains provided by this new caching scheme and more importantly,
that performance for the type of caching provided by QuerySQLCache has not
regressed.  Do you have any preliminary measurements that show the benefits
of this new caching and that OpenJPA hasn't regressed in performance from
the replacement of QuerySQLCache?  Also, I the doc updates didn't allude to
any sort of findBy caching like the former QuerySQLCache provided.
Admittedly, I haven't given the code a thorough review yet, but does this
feature no longer exist, is it not implemented yet, or is it simply not made
clear in the docs?

-Jeremy

On Thu, Jan 29, 2009 at 7:27 PM, <[email protected]> wrote:

> Author: ppoddar
> Date: Fri Jan 30 01:27:35 2009
> New Revision: 739123
>
> URL: http://svn.apache.org/viewvc?rev=739123&view=rev
> Log:
> OPENJPA-703: Prepared Query Cache
>
> <snip>

Reply via email to