[
https://issues.apache.org/jira/browse/OPENJPA-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673263#action_12673263
]
Albert Lee commented on OPENJPA-770:
------------------------------------
Tim, I took a look at the patch, It does what is asked for in the original
request.
To keep the changes cleaner and to a minimum, I wonder a class level
@AllowFailure can be applied to some of these tests instead of annotating in
every method. Also consider the use of @AllowFailure(value=false) to negate
test selection and/or exclusions.
Thanks for the patch.
Albert Lee.
> Use annotations instead of excluding tests in pom.xml
> -----------------------------------------------------
>
> Key: OPENJPA-770
> URL: https://issues.apache.org/jira/browse/OPENJPA-770
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Michael Dick
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-770.patch
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> In openjpa-persistence-jdbc/pom.xml there are a lot of excluded testcases.
> Instead of hard coding these in pom.xml we should use the new annotation that
> Pinaki introduced in the "parent" JIRA issue.
> The list of excluded tests can be found in pom.xml, here's a subsection of
> them
> <!-- exclude new tests that aren't passing yet -->
>
> <exclude>org/apache/openjpa/persistence/jpql/clauses/TestEJBQueryInterface.java</exclude>
>
> <exclude>org/apache/openjpa/persistence/kernel/TestInitialValueFetching.java</exclude>
>
> <exclude>org/apache/openjpa/persistence/kernel/TestOpenResultsCommit.java</exclude>
>
> <exclude>org/apache/openjpa/persistence/query/TestQuotedNumbersInFilters2.java</exclude>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
