[ 
https://issues.apache.org/jira/browse/OPENJPA-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12690105#action_12690105
 ] 

Michael Dick commented on OPENJPA-975:
--------------------------------------

Before committing the patch I'd like to make sure that the current behavior is 
the default. Ie on Oracle (or any database) we should still include ESCAPE 
('/') unless the user configures otherwise. 

The line in OracleDictionary that sets requiresSearchStringEscapeForLike should 
be removed, and the testcase will need updating to reflect that (set the 
property in order to test it at least when the DBDictionary is Oracle. The 
patch also includes an updated setClobString() method for Oracle that doesn't 
seem to be related to the problem. Is that intentional or did it creep in as 
part of another change? One other minor nit, there was a spot where the patch 
went beyond 80 characters, no big deal but it is something to keep an eye on.

Otherwise the patch looks good and I'd be happy to include it in 1.0.4 when the 
issues listed above are resolved.



> Oracle needs ability to not have an escape character for search strings.
> ------------------------------------------------------------------------
>
>                 Key: OPENJPA-975
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-975
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 1.2.0, 1.3.0, 2.0.0
>         Environment: Oracle
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 1.0.4, 1.2.2, 1.3.0, 2.0.0
>
>         Attachments: OPENJPA-975c.patch, OPENJPA-975c_1.0.x.patch, 
> OPENJPA-975c_1.0.x.patch, OPENJPA-975doc.patch
>
>
> Oracle application has a JPQL query that attempts to set a parameter to '\'. 
> '\' is not a reserved character with Oracle and the query will work if you 
> execute it "normally" with JDBC.
> OpenJPA automatically adds ESCAPE ('\') to every search SQL query.  As a 
> result the \ is interpreted as an escape indicator and the SQL will not 
> execute as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to