The purpose of AllowFailure is *not* to ignore a test from running. But to run the test and allow our test harness to continue even if the annotated test fails. If a JUnit4 annotation provides us such functionality, perhaps we can replace it. But remember that any solution is homegrown -- it is just a different home than your own:)
Hi all, The AllowFailure annotation is very useful in that it allows specific test methods to be ignored during a typical Maven build. The implementation, however is rather confusing as a "clean" build of OpenJPA will typically contain several stack traces from exceptions. Running these optional tests that currently do not pass just consumes CPU cycles that could be better spent elsewhere. I propose refactoring @AllowFailure to be called @OptionalTest (or just @Optional) and updating the supporting methods in PersistenceTestCase so that test methods (or classes) annotated with @OptionalTest are skipped unless a jvm system property is true (ie -Dopenjpa.optional.tests=true). I think this will save everyone's CPU cycles without violating the intent of @AllowFailure. In addition with this change we could resurrect the changes for OPENJPA-770 and we could clean up the root pom.xml a bit. Anyone else have strong opinions about @AllowFailure? -mike ----- Pinaki Poddar http://ppoddar.blogspot.com/ http://www.linkedin.com/in/pinakipoddar OpenJPA PMC Member/Committer JPA Expert Group Member -- View this message in context: http://n2.nabble.com/-DISCUSS--refactor-%40AllowFailure-tp2593705p2594325.html Sent from the OpenJPA Developers mailing list archive at Nabble.com.
