[
https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712382#action_12712382
]
Milosz Tylenda commented on OPENJPA-1090:
-----------------------------------------
Hi Tim & Donald. If I can have a remark I would suggest that the code will be
more readable and the patch much smaller if instead of:
testMethod() {
if (supportsAutoAssign) {
[method body]
}
}
we do:
testMethod() {
if (!supportsAutoAssign) {
return;
}
[method body]
}
This is how, for example, TestGenerationType does it (which, BTW, does not need
to be modified by the patch)
> Oracle failures due to the following warning "This database dictionary
> "Oracle" does not support auto-assigned column values. The column "pid" may
> not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
