[
https://issues.apache.org/jira/browse/OPENJPA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713995#action_12713995
]
Michael Dick commented on OPENJPA-1083:
---------------------------------------
Some comments on the patch for option 1.
It seems like the logic to obtain the foreign key name from the database
belongs in the ForeignKey or Constraint class. Adding a method called
loadName() or something similar seems cleaner.
That being said it's not obvious where we read the name from the database.
I also noticed that the patch always removes the FK from localTable
(DBDictionary.getDropForeignKeySQL) but only adds it if it wasn't found.
The last suggestion I'd make is to add some sort of unit test just for this
change. I know it shows up in other testcases on Oracle, but it'd be nice to
just validate this part of the change.
> org.apache.openjpa.persistence.kernel.TestEJBState fails with two exceptions
> ORA-00904 and ORA-02275 against oracleDB.
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1083
> URL: https://issues.apache.org/jira/browse/OPENJPA-1083
> Project: OpenJPA
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Ravi P Palacherla
> Assignee: Michael Dick
> Attachments: OPENJPA-1083.patch, OPENJPA-1083_option1.patch,
> OPENJPA-1083_option2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
