Hi Kevin, > 1) Under what conditions should we be checking in these generated metamodel classes? To construct, compile and test 'typesafe' Criteria Query.
> We don't want the metamodel classes generated for all of our Entities, do we? No, we do not. I have deactivated the annotation processor (that generates these metamodel classes) as a part of compilation for similar reasons. > So, how are we determining which Entities should have generated metamodel classes? The ones that participate in testing Criteria Query. > 2) Our processing in this arena can help define a "best practice" for our eventual JPA 2.0 users. Correct. > And, whether these should be checked into SVN or not. These classes must be available at compile-time for user/test application. Within TeamCity, I could not think of any other alternative to *not* checking them into SVN. However, I had not checked them in initially. When Fay joined to develop tests, I took that as an opportunity to observe an 'unbiased user' and noticed that she generated these meta-model classes, used them to write the queries and checked them into SVN. Kevin Sutter wrote: > > A few interesting points with this discussion... > > 1) Under what conditions should we be checking in these generated > metamodel > classes? We don't want the meta-model classes generated for all of our > Entities, do we? Seems like a waste of build time. So, how are we > determining which Entities should have generated meta-model classes? > > 2) Our processing in this arena can help define a "best practice" for our > eventual JPA 2.0 users. That is, how and when to do the meta-model > generation. How to package these generated classes for the application. > And, whether these should be checked into SVN or not. > > 3) And, why do we continue to have the 80 column limit for our source > files? :-) It seems so archaic. > > Kevin > > On Fri, Jun 5, 2009 at 8:43 AM, Michael Dick > <[email protected]>wrote: > >> Are the files generated during the build process or are they committed to >> SVN? >> >> If they're part of the build process then it's fair to exclude them, if >> they're generated and then committed to SVN then I think they should >> comply >> before we commit them. >> >> -mike >> >> On Fri, Jun 5, 2009 at 8:36 AM, Pinaki Poddar <[email protected]> wrote: >> >> > >> > Hi, >> > > If there's any way to exclude these files >> > 1. These files are created under openjpa-persistence-jdbc module's test >> > packages >> > 2. They are always named with a underscore at the end i.e. say >> Person_.java >> > >> > >> > Craig L Russell wrote: >> > > >> > > >> > > On Jun 4, 2009, at 9:38 AM, Pinaki Poddar wrote: >> > > >> > >> >> > >> Hi, >> > >> We are now checking in *.java files for canonical meta-model >> > >> classes in >> > >> SVN. Source code for these classes are auto-generated and may exceed >> > >> 80-column per line. Noticed some work on enforcing 80-column limit >> > >> on test >> > >> source code -- can't locate the exact issue -- but anyway that work >> > >> must >> > >> consider exception for these auto-generated source files. >> > > >> > > +1 Let's not worry about generated files exceeding the 80 character >> > > line limit. If there's any way to exclude these files from the >> checker >> > > this should be an exception. >> > > >> > > Craig >> > >> >> > >> >> > >> ----- >> > >> Pinaki Poddar http://ppoddar.blogspot.com/ >> > >> >> > >> http://www.linkedin.com/in/pinakipoddar >> > >> OpenJPA PMC Member/Committer >> > >> JPA Expert Group Member >> > >> -- >> > >> View this message in context: >> > >> >> > >> http://n2.nabble.com/80-column-line-width---auto-generated-model-classes-tp3025746p3025746.html >> > >> Sent from the OpenJPA Developers mailing list archive at Nabble.com. >> > >> >> > > >> > > Craig L Russell >> > > Architect, Sun Java Enterprise System http://db.apache.org/jdo >> > > 408 276-5638 mailto:[email protected] >> > > P.S. A good JDO? O, Gasp! >> > > >> > > >> > > >> > > >> > >> > >> > ----- >> > Pinaki Poddar http://ppoddar.blogspot.com/ >> > >> > http://www.linkedin.com/in/pinakipoddar >> > OpenJPA PMC Member/Committer >> > JPA Expert Group Member >> > -- >> > View this message in context: >> > >> http://n2.nabble.com/80-column-line-width---auto-generated-model-classes-tp3025746p3030320.html >> > Sent from the OpenJPA Developers mailing list archive at Nabble.com. >> > >> > >> > > ----- Pinaki Poddar http://ppoddar.blogspot.com/ http://www.linkedin.com/in/pinakipoddar OpenJPA PMC Member/Committer JPA Expert Group Member -- View this message in context: http://n2.nabble.com/80-column-line-width---auto-generated-model-classes-tp3025746p3030862.html Sent from the OpenJPA Developers mailing list archive at Nabble.com.
