[
https://issues.apache.org/jira/browse/OPENJPA-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729310#action_12729310
]
Milosz Tylenda commented on OPENJPA-1168:
-----------------------------------------
This reminds me of a test case which sometimes fails for me while running
against MySQL and which I did not have time to look at. Maybe this is connected
although the test case is single-threaded. The stack trace I am receiving is:
testDefaultValues(org.apache.openjpa.persistence.generationtype.TestGeneratedValues)
Time elapsed: 0.787 sec <<< FAILURE!
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertFalse(Assert.java:34)
at junit.framework.Assert.assertFalse(Assert.java:41)
at
org.apache.openjpa.persistence.generationtype.TestGeneratedValues.testDefaultValues(TestGeneratedValues.java:49)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at
org.apache.openjpa.persistence.test.PersistenceTestCase.runBare(PersistenceTestCase.java:466)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at
org.apache.openjpa.persistence.test.PersistenceTestCase.run(PersistenceTestCase.java:181)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at sun.reflect.GeneratedMethodAccessor58.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
The TestGeneratedValues.java:49 contains:
assertFalse(gv.getUuidstring().equals(gv2.getUuidstring()));
This means UUID generator sometimes generates duplicates.
> NPE in UUIDGenerator.initializeForType1()
> -----------------------------------------
>
> Key: OPENJPA-1168
> URL: https://issues.apache.org/jira/browse/OPENJPA-1168
> Project: OpenJPA
> Issue Type: Bug
> Components: lib
> Reporter: Rick Curtis
> Assignee: Michael Dick
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-1168.patch, OPENJPA-1168.patch
>
>
> When UUIDGenerator.createType1() is called by more than one thread at
> *nearly* the same time AND UUIDGenerator.createType1() wasn't called
> previously, a small timing window exists where a NPE will result.
> Scenario:
> Thread 1 calls UUIDGenerator.createType1() and RANDOM == null so
> initializeForType1() is called. While that thread is in initializeForType1(),
> it sets the static variable RANDOM so that value is no longer null. Now
> Thread 2 calls UUIDGenerator.createType1() and RANDOM is no longer null, so
> it proceeds to the call System.arraycopy(IP, 0, uuid, 10, IP.length);. At
> this point Thread 1 hasn't got to initializing IP yet, so Thread 2 gets hits
> a NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
