+    /**
+     * Set whether this Broker will generate verbose optimistic lock
exceptions when batching
+     * operations. Defaults to true. <<<<- ????
+     *
+     * @param b
+     */
+    public void setSuppressBatchOLELogging(boolean b) {

Should the default be "false"?  Based on "private boolean
_suppressBatchOLELogging = false;"

Albert Lee.

On Tue, Dec 8, 2009 at 10:03 AM, <[email protected]> wrote:

> Author: curtisr7
> Date: Tue Dec  8 16:03:56 2009
> New Revision: 888453
>
> URL: http://svn.apache.org/viewvc?rev=888453&view=rev
> Log:
> OPENJPA-1415: Suppress batched OLE messages.
>
> Modified:
>
>  
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/BrokerImpl.java
>
>  
> openjpa/trunk/openjpa-kernel/src/main/resources/org/apache/openjpa/kernel/localizer.properties
>
> Modified:
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/BrokerImpl.java
> URL:
> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/BrokerImpl.java?rev=888453&r1=888452&r2=888453&view=diff
>
> ==============================================================================
> ---
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/BrokerImpl.java
> (original)
> +++
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/kernel/BrokerImpl.java
> Tue Dec  8 16:03:56 2009
> @@ -229,6 +229,7 @@
>     private boolean _orderDirty = false;
>     private boolean _cachePreparedQuery = true;
>     private boolean _cacheFinderQuery = true;
> +    private boolean _suppressBatchOLELogging = false;
>
>     // status
>     private int _flags = 0;
> @@ -836,6 +837,23 @@
>                 _transCallbackMode);
>     }
>
> +    /**
> +     * Set whether this Broker will generate verbose optimistic lock
> exceptions when batching
> +     * operations. Defaults to true.
> +     *
> +     * @param b
> +     */
> +    public void setSuppressBatchOLELogging(boolean b) {
> +        _suppressBatchOLELogging = b;
> +    }
> +
> +    /**
> +     * Return whether this Broker will generate verbose optimistic lock
> exceptions when batching
> +     * operations.
> +     */
> +    public boolean getSuppressBatchOLELogging() {
> +        return _suppressBatchOLELogging;
> +    }
>     ///////////
>     // Lookups
>     ///////////
> @@ -2235,8 +2253,13 @@
>                     failed.add(f);
>             }
>         }
> -        if (opt && !failed.isEmpty())
> -            return new OptimisticException(failed, t);
> +        if (opt && !failed.isEmpty()) {
> +            if(_suppressBatchOLELogging == true){
> +                return new
> OptimisticException(_loc.get("broker-suppressing-exceptions",t.length));
> +            }else{
> +                return new OptimisticException(failed, t);
> +            }
> +        }
>         if (opt)
>             return new OptimisticException(t);
>         return new StoreException(_loc.get("rolled-back")).
>
> Modified:
> openjpa/trunk/openjpa-kernel/src/main/resources/org/apache/openjpa/kernel/localizer.properties
> URL:
> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/resources/org/apache/openjpa/kernel/localizer.properties?rev=888453&r1=888452&r2=888453&view=diff
>
> ==============================================================================
> ---
> openjpa/trunk/openjpa-kernel/src/main/resources/org/apache/openjpa/kernel/localizer.properties
> (original)
> +++
> openjpa/trunk/openjpa-kernel/src/main/resources/org/apache/openjpa/kernel/localizer.properties
> Tue Dec  8 16:03:56 2009
> @@ -404,6 +404,7 @@
>     an active connection to the database.
>  no-interface-metadata: No metadata was found for managed interface {0}.
>  fetch-configuration-stack-empty: Fetch configuration stack is empty.
> +broker-suppressing-exceptions: Suppressing "{0}" exceptions.
>  gap-query-param: Parameter {1} for query "{0}" exceeds the number of {2} \
>        bound parameters with following values "{3}". This can happen if you
> have \
>        declared but missed to bind values for one or more parameters.
>
>
>


-- 
Albert Lee.

Reply via email to