Hi Milosz, Yes, it was an oversight, I should not have checked in TestUpdateWithSubSelect change under OPENJPA-1461; it has nothing to do with XML column mapping. This is a failure seen when running mvn test for Oracle. There are still 3 outstanding failures for Oracle: *TestDetachNoStateField.testIsDetchedNoStateManagerZeroVersionField **TestDetachNoStateField.testPersistRelationshipToDetchedEntityZeroVersion **TestTypesafeCriteria.testCurrentTimeReturnsSQLTypes (org.apache.openjpa.persistence.criteria) * <openjpa-2.0.0-SNAPSHOT-rexported fatal store error> org.apache.openjpa.persistence.RollbackException: The transaction has been rolled back.I will open a new JIRA issue for the above failures.
Catalina On Fri, Jan 15, 2010 at 11:50 AM, Milosz Tylenda (JIRA) <j...@apache.org>wrote: > > [ > https://issues.apache.org/jira/browse/OPENJPA-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800882#action_12800882] > > Milosz Tylenda commented on OPENJPA-1461: > ----------------------------------------- > > Hi Catalina, I am wondering whether your commit to > TestUpdateWithSubSelect.java is related to the fix or an oversight? > > > > Incorrect Oracle CREATE TABLE DDL for XML column > > ------------------------------------------------ > > > > Key: OPENJPA-1461 > > URL: https://issues.apache.org/jira/browse/OPENJPA-1461 > > Project: OpenJPA > > Issue Type: Bug > > Components: jdbc > > Affects Versions: 2.0.0 > > Reporter: Catalina Wei > > Assignee: Catalina Wei > > Fix For: 2.0.0 > > > > > > A regression is found that the DDL for XML type is incorrectly generated > for Oracle backend. > > <openjpa-2.0.0-SNAPSHOT-rexported nonfatal general error> > org.apache.openjpa.persistence.PersistenceException: ORA-00907: missing > right parenthesis > > {stmnt 562241923 CREATE TABLE TORDER (oid NUMBER NOT NULL, amount > NUMBER, delivered NUMBER, shipAddress XMLType(255), version NUMBER, > CUSTOMER_COUNTRYCODE VARCHAR2(255), CUSTOMER_ID NUMBER, PRIMARY KEY (oid))} > [code=907, state=42000] > > at > org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:553) > > at > org.apache.openjpa.jdbc.meta.MappingTool.record(MappingTool.java:453) > > at > org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.synchronizeMappings(JDBCBrokerFactory.java:155) > > at > org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.synchronizeMappings(JDBCBrokerFactory.java:159) > > at > org.apache.openjpa.jdbc.kernel.JDBCBrokerFactory.newBrokerImpl(JDBCBrokerFactory.java:117) > > at > org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(AbstractBrokerFactory.java:207) > > at > org.apache.openjpa.kernel.AbstractBrokerFactory.newBroker(AbstractBrokerFactory.java:194) > > at > org.apache.openjpa.kernel.DelegatingBrokerFactory.newBroker(DelegatingBrokerFactory.java:152) > > at > org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:200) > > at > org.apache.openjpa.persistence.EntityManagerFactoryImpl.createEntityManager(EntityManagerFactoryImpl.java:151) > > at > org.apache.openjpa.persistence.xmlmapping.query.TestXMLCustomerOrder.setUp(TestXMLCustomerOrder.java:75) > > at junit.framework.TestCase.runBare(TestCase.java:125) > > at > org.apache.openjpa.persistence.test.AbstractPersistenceTestCase.runBare(AbstractPersistenceTestCase.java:501) > > at > org.apache.openjpa.persistence.test.AbstractPersistenceTestCase.runBare(AbstractPersistenceTestCase.java:477) > > at junit.framework.TestResult$1.protect(TestResult.java:106) > > at junit.framework.TestResult.runProtected(TestResult.java:124) > > at junit.framework.TestResult.run(TestResult.java:109) > > at junit.framework.TestCase.run(TestCase.java:118) > > at > org.apache.openjpa.persistence.test.AbstractPersistenceTestCase.run(AbstractPersistenceTestCase.java:177) > > at junit.framework.TestSuite.runTest(TestSuite.java:208) > > at junit.framework.TestSuite.run(TestSuite.java:203) > > at > org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:128) > > at > org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) > > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460) > > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673) > > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386) > > at > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196) > > Caused by: org.apache.openjpa.lib.jdbc.ReportingSQLException: ORA-00907: > missing right parenthesis > > {stmnt 562241923 CREATE TABLE TORDER (oid NUMBER NOT NULL, amount > NUMBER, delivered NUMBER, shipAddress XMLType(255), version NUMBER, > CUSTOMER_COUNTRYCODE VARCHAR2(255), CUSTOMER_ID NUMBER, PRIMARY KEY (oid))} > [code=907, state=42000] > > Correct DDL should be: > > CREATE TABLE TORDER (oid NUMBER NOT NULL, amount NUMBER, delivered > NUMBER, shipAddress XMLType, version NUMBER, CUSTOMER_COUNTRYCODE > VARCHAR2(255), CUSTOMER_ID NUMBER, PRIMARY KEY (oid)) > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
