[ 
https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841504#action_12841504
 ] 

Jeremy Bauer commented on OPENJPA-1530:
---------------------------------------

I agree with Milosz.  The property does not go beyond the scope of the 
dictionary so it should be localized to the MySQL dictionary.  For example:  

<property name="openjpa.jdbc.DBDictionary" value="mysql(Engine=ndbcluster)"/>.

You just need to provide a getter and setter (or public field) for "Engine" in 
the MySQL dictionary and the config framework will take care of setting the 
value.  Also, if you add a new dictionary value please update the OpenJPA docs 
specific to the MySQL dictionary.  Oh, and the print statement needs to be 
removed.  :-)

> MySQL storage engine support
> ----------------------------
>
>                 Key: OPENJPA-1530
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1530
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>            Reporter: Craig L Russell
>            Assignee: Craig L Russell
>            Priority: Minor
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: openjpa-1530.patch
>
>
> The MySQLDictionary currently supports only TYPE innodb. There is a skeleton 
> for support of this element but there is no way to change it from the default.
> Also, according to the MySQL documentation 
> http://dev.mysql.com/doc/refman/5.1/en/create-table.html  TYPE is deprecated. 
> The recommended (and supported) keyword is ENGINE. 
> "Since MySQL 5.1.8, it produces a warning. It will be removed in a future 
> MySQL release. You should not use TYPE in any new applications, and you 
> should immediately begin conversion of existing applications to use ENGINE 
> instead."
> I propose to change TYPE to ENGINE, and to provide a way for the user to 
> specify which engine to use.
> I need some feedback on this: A property, mysql.engine, with a default of 
> innodb (for compatibility) can be specified by the user in order to create 
> tables using any of the supported engines. Can the property be put onto the 
> command line? Can the property be added to persistence.xml? Can the property 
> be added to the maven profile properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to