I think it's more likely that it just didn't fix the problem. We're getting intermittent TimeoutExceptions from this testcase - run it a second time and it passes.
I naively thought that it was just a matter of load on the system so I raised the timeout. I took a look at the latest TC builds and it looks like they've passed - since my change anyway. The test still fails occasionally though. I'm happy to revert the change if you're seeing different results. -mike On Fri, Aug 13, 2010 at 4:08 PM, Donald Woods <[email protected]> wrote: > This seems to be causing a new failure on Derby under JDK5 and MSSQL > 2008 under JDK6 - > > TestQueryMultiThreaded.testQueryParameterEntity(org.apache.openjpa.slice) > junit.framework.AssertionFailedError: Failed > java.util.concurrent.TimeoutException > java.util.concurrent.TimeoutException > at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228) > junit.framework.AssertionFailedError: Failed > java.util.concurrent.TimeoutException > java.util.concurrent.TimeoutException > at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:228) > at java.util.concurrent.FutureTask.get(FutureTask.java:91) > at > > org.apache.openjpa.slice.TestQueryMultiThreaded.waitForTermination(TestQueryMultiThreaded.java:341) > at > > org.apache.openjpa.slice.TestQueryMultiThreaded.testQueryParameterEntity(TestQueryMultiThreaded.java:333) > > > On 8/12/10 10:03 PM, [email protected] wrote: > > Author: mikedd > > Date: Fri Aug 13 02:03:48 2010 > > New Revision: 985067 > > > > URL: http://svn.apache.org/viewvc?rev=985067&view=rev > > Log: > > Increase timeout value for slice testcase > > > > Modified: > > > openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java > > > > Modified: > openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java > > URL: > http://svn.apache.org/viewvc/openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java?rev=985067&r1=985066&r2=985067&view=diff > > > ============================================================================== > > --- > openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java > (original) > > +++ > openjpa/trunk/openjpa-slice/src/test/java/org/apache/openjpa/slice/TestQueryMultiThreaded.java > Fri Aug 13 02:03:48 2010 > > @@ -49,6 +49,7 @@ public class TestQueryMultiThreaded exte > > private int VALUE_MIN = 100; > > private int VALUE_MAX = VALUE_MIN + POBJECT_COUNT - 1; > > private static int THREADS = 5; > > + private static int MAX_TIMEOUT = 300; > > private ExecutorService group; > > private Future[] futures; > > > > @@ -337,7 +338,7 @@ public class TestQueryMultiThreaded exte > > try { > > for (Future f : futures) > > try { > > - f.get(60, TimeUnit.SECONDS); > > + f.get(MAX_TIMEOUT, TimeUnit.SECONDS); > > } catch (TimeoutException te) { > > fail("Failed " + te + "\r\n" + getStackDump(te)); > > } catch (ExecutionException e) { > > > > > > >
