[
https://issues.apache.org/jira/browse/OPENJPA-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981266#action_12981266
]
Michael Dick commented on OPENJPA-1593:
---------------------------------------
I took a quick look through the patch, and nothing major jumped out at me.
My main concern is that the new managed runtime gets tested. Can you elaborate
on what you've done to exercise the new class?
One other nit - I noticed a lot of one line if statements that don't have curly
braces, could you add those in?
> Create an OSGiManagedRuntime
> ----------------------------
>
> Key: OPENJPA-1593
> URL: https://issues.apache.org/jira/browse/OPENJPA-1593
> Project: OpenJPA
> Issue Type: Sub-task
> Components: osgi
> Affects Versions: 2.0.0-beta
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.2.0
>
> Attachments: OPENJPA-1593-1.patch
>
>
> Follow-on to OPENJPA-1524 to create a generic OSGiManagedRuntime class that
> would work for vendors/frameworks other than Apache Aries.
> Tim's original suggestion was - One implementation suggestion would be to use
> a ServiceTracker to keep track of the JTA services. This would allow for lazy
> lookup and also provide a notification if the service is unregistered.
> This should then be possible to implement as a relatively simple subclass of
> RegistryManagedRuntime that overrides getTransactionManager(). I don't know
> if you have a nice mechanism to pass a BundleContext yet, but I don't think
> that should pose a significant problem.
> Now that we have a BundleUtils.java to require OSGi classes in our runtime,
> we should be able to lookup
> "javax.transaction.TransactionSynchronizationRegistry" from the
> ServiceRegistry to use, instead of relying on the current JNDI lookup which
> is Aries specific.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
