[ 
https://issues.apache.org/jira/browse/OPENJPA-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019067#comment-13019067
 ] 

Pinaki Poddar commented on OPENJPA-1979:
----------------------------------------

> XML mapping parser as well. 
Yes, of course.

> lacking a jUnit f
The test case patch has ASF license granted. One can consider including it. The 
test case does not conform setUp() routine though.

Another couple of points:
a)   There are few more rules to determine whether a specification denotes 
constant-valued column (ref: MappingInfo.meregColumn(...) and assignment of the 
local boolean variable named 'constant'). The quick patch does not work out 
those rules.

b) The downstream effect of changing DBIdentifierType to CONSTANT instead of 
usual COLUMN not investigated. It was just done to stop the columnName being 
delimited. 

> Regression for non-standard joins with constant column values 
> --------------------------------------------------------------
>
>                 Key: OPENJPA-1979
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1979
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc, kernel
>    Affects Versions: 2.0.0-M1, 2.0.0
>            Reporter: Pinaki Poddar
>             Fix For: 2.1.0
>
>         Attachments: OPENJPA-1979.patch.1.txt, Test-1979.zip
>
>
> The non-standard join can use constant column values by enclosing them in 
> single-quote character. This behavior is regressed. The likely cause of this 
> regression is new delimiting support for schema elements introduced in JPA 
> 2.0. The constant column value used to be detected during schema definition 
> based on the assumption of the name being enclosed in single-quote. Due to 
> introduction of delimiting capability, the constant value is now enclosed in 
> double-quote followed by a single-quote.   
> The visible effect is failure to define schema for non-standard join with 
> constant values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to