[ 
https://issues.apache.org/jira/browse/OPENJPA-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056249#comment-13056249
 ] 

Pinaki Poddar commented on OPENJPA-2020:
----------------------------------------

Making carte blanche changes sensitive/critical constructs to private fields as 
protected is a poor design practice.


We have met similar situation before. And the good practice is to 
a) provide the nature and reason of extension one is looking for. This way some 
alternatives can be suggested that does not require such changes.
b)  It is understood that some work may require some degree of access 
relaxation. But it is more prudent to make those relaxation as and when they 
are required




> Make some members of StateManagerImpl protected to allow for greater 
> extensability
> ----------------------------------------------------------------------------------
>
>                 Key: OPENJPA-2020
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2020
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: kernel
>    Affects Versions: 2.1.0, 2.2.0
>            Reporter: Rick Curtis
>            Assignee: Rick Curtis
>             Fix For: 2.1.1, 2.2.0
>
>
> With this JIRA I'm going to change a number of methods / fields to protected 
> to allow for greater extensibility.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to