[
https://issues.apache.org/jira/browse/OPENJPA-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708853#comment-13708853
]
Rick Curtis commented on OPENJPA-2410:
--------------------------------------
A few comments on your patch :
* Remove the changes to XMLFormatter.java.
* Fix the the spacing on checkstyle.xml.
* Can you move the suppressions.xml so that it is under the openjpa-project
module?
* Remove IdentifierUtilImpl from the supressions.xml file, and remove the
System.out call from IdentifierUtilImpl:368
Otherwise, the patch looks good.
> Detection for Illegal System.out/err.print(ln) Statements in OpenJPA
> --------------------------------------------------------------------
>
> Key: OPENJPA-2410
> URL: https://issues.apache.org/jira/browse/OPENJPA-2410
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 2.3.0
> Reporter: Di Wu Lau
> Assignee: Rick Curtis
> Priority: Minor
> Fix For: 2.3.0
>
> Attachments: OPENJPA-2410.patch
>
>
> OpenJPA may contain illegal System.out/err.print(ln) statements. Those
> statements should be detected and an error should be thrown to the user so
> they are aware of them and remove them from the code. Certain
> System.out/err.print(ln) statements are allowed such as for tools and testing
> purpose. Those will be filtered out and will not cause an error.
> Files modified:
> checkstyle.xml
> pom.xml
> File added:
> suppressions.xml
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
