[ 
https://issues.apache.org/jira/browse/OPENJPA-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786326#comment-13786326
 ] 

Mark Struberg commented on OPENJPA-2283:
----------------------------------------

Kevin, if you take org.objectweb.asm as default, then you risk to get into deep 
troubles. There was a reason that there is a shaded version of asm used in 
OpenEJB, Geronimo, OpenWebBeans, Spring, etc. All those projects basically got 
to a point where they were broken sometimes because they use plain ASM.

The reason is that ASM folks changed their API over time and introduced 
backward incompatibilities. But they didn't change the package names. 
So whenever a custom WAR or EAR deployed in the container of your choice brings 
an own ASM version, then you can never be sure that it is compatible with 
OpenJPA! And I really don't like to render OpenJPA useless only because some 
customer projects bring an old ASM version as dependency.

Of course, I can see your point with ASM3 as primary target, thus I'd suggest 
to set the ordering as following:

# xbean-asm3
# xbean-asm4
# asm-spring
# asm native

> Upgrade to ASM 4 dependency
> ---------------------------
>
>                 Key: OPENJPA-2283
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2283
>             Project: OpenJPA
>          Issue Type: New Feature
>          Components: Enhance
>    Affects Versions: 2.3.0
>            Reporter: Kevin Sutter
>             Fix For: 2.3.0
>
>         Attachments: openjpa-2283.problem.patch
>
>
> OpenJPA currently has a dependency on ASM 3.2 for some post-enhancement 
> processing to fix up the stack map tables (Java 7 requirement).  The latest 
> release of ASM is 4.1, which just came out last week.  The immediate need is 
> to move up to ASM 4.0.  We can entertain 4.1 at a later date.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to