Hi Albert, all!
* As for the key: you can find my key in https://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS As the release is correctly signed this is not a blocker I think. Will of course add my key to openjpa as well now. * For the tag name: it's just a tag. Feel free to rename the tag. This does not affect the sources which is btw the only thing an ASF release constitutes of. * Notice: yikes, how long did this not get fixed? Reminds me that we should go for 2014 immediately and do a check on all my projects in january again. Is this really a blocker? Not sure myself. * OPENJPA-2335 sorry, my fault. Did reopen it, fixed it in branch and did not close it. Done now. It's in the release notes, so all is fine. * OPENJPA-2450 No idea why this got assigned as 'fixed in' 2.3.0. Removed it from there. This JIRA even got created after I started with the release process. anything left? Gonna create the JavaDoc and try to push it from my office computer. If this doesn't work (firewall rules) then I try and push it in the afternoon. No worries, if you feel there are still blocker in there then I try another respin within this week. In any case, thanks for the review, Albert! After the VOTE finally succeeds I gonna apply all my changes from branch to trunk. txs and LieGrue, strub ----- Original Message ----- > From: Albert Lee <allee8...@gmail.com> > To: open-jpa-dev <dev@openjpa.apache.org>; Mark Struberg <strub...@yahoo.de> > Cc: > Sent: Sunday, 17 November 2013, 3:42 > Subject: Re: [VOTE] Release Apache OpenJPA-2.3.0 > > Mark, > > Thanks you for putting up the release. > > -1 for the following observations: > > * I don't see your signature in svn.apache.org/repos/asf/openjpa/KEYS file. > See http://openjpa.apache.org/release-setup.html - Create a GPG key - step > 4. > * should the tags/openjpa-parent-2.3.0 be tags/2.3.0 > * From https://issues.apache.org/jira/browse/OPENJPA/fixforversion/12319463, > there are still 1 JIRA (OPENJPA-2450) "in Progress" and 1 JIRA > (OPENJPA-2335) in "Reopened" state. These need to be resolved. > * In RELEASE-NOTES.html, > ** "Notices" section, the copyright should be "Copyright > 2006,2013 The > Apache Software Foundation". > ** End of the document, the copyright should be "Copyright (C) 2006,2012 > Apache Software Foundation. Licensed under Apache License 2.0." > * openjpa-project/src/doc/manual/manual.html needs to update the copyright > to 2013 > <title>Apache OpenJPA 2.3 User's Guide</title> > <copyright> > <year>2006-2013</year> > <holder>The Apache Software Foundation</holder> > * Can you post the javadoc url for viewing? > > Sorry for the -1 vote. > Albert Lee. > > > On Wed, Nov 13, 2013 at 3:41 PM, Mark Struberg <strub...@yahoo.de> wrote: > >> Hi! >> >> I did prepare the OpenJPA-2.3.0 release yesterday and like to call a VOTE >> on it. >> Just did some in depth testing with it on a few private projects and >> Romain and David did run TomEE tests (thus TCKed) on it. >> >> The staging repository can be found here: >> https://repository.apache.org/content/repositories/orgapacheopenjpa-117/ >> >> Here is the source release zip >> >> > https://repository.apache.org/content/repositories/orgapacheopenjpa-117/org/apache/openjpa/openjpa-parent/2.3.0/openjpa-parent-2.3.0-source-release.zip >> sha1: e36ce9727ab4b37a31411ca723bb37b502a00d38 >> >> >> [+1] ship it! >> [+0] meh, don't care >> [-1] stop, becasue ${reason} >> >> The VOTE is open for 72h. >> >> >> Please note that I did not yet push the site. Will do this once the VOTE >> succeeds and the staging gets closed. >> >> >> >> regards, >> the OpenJPA Team >> > > > > -- > Albert Lee. >
