[
https://issues.apache.org/jira/browse/OPENJPA-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973104#comment-13973104
]
Romain Manni-Bucau edited comment on OPENJPA-2492 at 4/19/14 12:51 PM:
-----------------------------------------------------------------------
we should surely only use ConcurrentMap (interface) and not concurrent hash map
which has signature issues.
wdyt?
edit: an alternative is to implement ConcurrentMap ourself delegating to a
ConcurrentHashMap (facade), this way signatures will be fine
edit 2: looked deeper some tests and we rely on Map interfaces so we can just
ignore this new keySet method from java 8 (+ I think that's ok from a spec
point of view)
was (Author: romain.manni-bucau):
we should surely only use ConcurrentMap (interface) and not concurrent hash map
which has signature issues.
wdyt?
edit: an alternative is to implement ConcurrentMap ourself delegating to a
ConcurrentHashMap (facade), this way signatures will be fine
> TestConcurrentMap error with Java 8
> -----------------------------------
>
> Key: OPENJPA-2492
> URL: https://issues.apache.org/jira/browse/OPENJPA-2492
> Project: OpenJPA
> Issue Type: Sub-task
> Components: build / infrastructure, Enhance, jpa
> Affects Versions: 2.4.0
> Environment: Java 8
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build 1.8.0-b132)
> Java HotSpot(TM) Client VM (build 25.0-b70, mixed mode)
> Reporter: Kevin Sutter
>
> One more test failure while running with Java 8. Since Java 8 introduced
> some new methods on the Map interface, this is probably related. We are
> getting a VerifyError related to the keySet signature:
> Tests in error:
> testConcurrentMap001(org.apache.openjpa.persistence.relations.TestConcurrentMap)
> <error message="(class:
> org/apache/openjpa/util/java$util$concurrent$ConcurrentHashMap$4$proxy,
> method: keySet signature:
> ()Ljava/util/concurrent/ConcurrentHashMap$KeySetView;) Wrong return type in
> function" type="java.lang.VerifyError">java.lang.VerifyError: (class:
> org/apache/openjpa/util/java$util$concurrent$ConcurrentHashMap$4$proxy,
> method: keySet signature:
> ()Ljava/util/concurrent/ConcurrentHashMap$KeySetView;) Wrong return type in
> function
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:340)
> at
> org.apache.openjpa.util.GeneratedClasses.loadBCClass(GeneratedClasses.java:68)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
