There's a few things I'm trimming, plus when I run a regular "mvn clean install" locally, I've noticed the absence of the sure-fire reports for openjpa-persistence-jdbc - we can't afford to not have unit tests running so the patch is not ready to go live yet.
This pretty much affects all of the various openjpa/branches (my patch was prepared using the 2.2.x branch). I did notice that trunk was building with java 7, while 2.2.x was building with java 8 - how can we get that set to build with java 7 for the rest of the branches? The OpenJPA runtime is java 8 forward compatible, but I don't believe the build process itself (unless things have changed) can run with java 8. Let me see what Syncope does and I'll get back to you on that bullet point. On Mon, Jun 20, 2016 at 1:53 AM, Francesco Chicchiriccò (JIRA) < [email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/OPENJPA-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339080#comment-15339080 > ] > > Francesco Chicchiriccò commented on OPENJPA-2645: > ------------------------------------------------- > > The patch looks generally fine to me (as it is mostly meant to polish and > update the poms); some observations / questions: > > # which "fix-for-versions" are we going to set on this issue, e.g. which > branches are we going to apply such fixes to? > # to me, some aspects of this patch - which you say are ported from trunk > - should be backported to trunk as well (dependency / plugin versions, > mostly) > # can we take a different approach for {{<checkstyle.config.location>}}, > as we do [in Syncope| > https://github.com/apache/syncope/blob/master/pom.xml#L1504]? > > > Doc Build for most branch releases are broken > > --------------------------------------------- > > > > Key: OPENJPA-2645 > > URL: https://issues.apache.org/jira/browse/OPENJPA-2645 > > Project: OpenJPA > > Issue Type: Bug > > Components: build / infrastructure > > Affects Versions: 1.1.1, 1.2.4, 1.3.0, 2.0.3, 2.1.2, 2.3.1, 2.2.x > > Reporter: Jody Grassel > > Assignee: Jody Grassel > > Attachments: openjpa-2646.patch > > > > > > Except for the trunk release, it appears that the doc build is broken > for the branch releases (for example, > https://ci.apache.org/builders/openjpa-2.2.x-docs/builds/320) -- this > needs to be corrected as this has resulted in broken links in the OpenJPA > documentation page. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
