Hi Maxim, looks integrable to me, just wondered if we want more config for the pool (and not hardcode the maxwait). For MySQL a bit +1
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le jeu. 2 août 2018 à 13:52, Maxim Solodovnik <[email protected]> a écrit : > Hello All, > > were you able to take a look at the patches? Are they good enough? > On Thu, Jul 19, 2018 at 6:03 PM Maxim Solodovnik <[email protected]> > wrote: > > > > Hello Mark, > > > > Could you please take a look at these 2 JIRAs: > > 1) https://issues.apache.org/jira/browse/OPENJPA-2567 (from 2015 ...) > > 2) https://issues.apache.org/jira/browse/OPENJPA-2744 > > > > will create patch for commons-collections is these 2 will be OK > > Thanks in advance > > > > On Thu, Jul 19, 2018 at 12:54 PM Mark Struberg > > <[email protected]> wrote: > > > > > > Jira with the diff would really be great! > > > > > > LieGrue, > > > strub > > > > > > > > > > Am 19.07.2018 um 07:07 schrieb Maxim Solodovnik < > [email protected]>: > > > > > > > > My bad, > > > > > > > > full build was successful after I clean up my changes to pom.xml > (have > > > > changed apache parent version to 20) > > > > sorry for the noise > > > > > > > > Am I right thinking the only way to propose PR is to attach patch to > the JIRA? > > > > On Wed, Jul 18, 2018 at 8:06 PM Maxim Solodovnik < > [email protected]> wrote: > > > >> > > > >> Actually it was full build :( > > > >> Maybe I missed something? > > > >> > > > >> WBR, Maxim > > > >> (from mobile, sorry for the typos) > > > >> > > > >> On Wed, Jul 18, 2018, 19:36 Mark Struberg <[email protected]> > wrote: > > > >>> > > > >>> Hi Maxim! > > > >>> > > > >>> I think you first need to run a full build with mvn clean install. > > > >>> And only then you can build the docbook stuff afair. > > > >>> > > > >>> LieGrue, > > > >>> strub > > > >>> > > > >>>> Am 17.07.2018 um 06:58 schrieb Maxim Solodovnik < > [email protected]>: > > > >>>> > > > >>>> Hello All, > > > >>>> > > > >>>> I would like to propose the patch with some library updates > > > >>>> > > > >>>> commons-collections > > > >>>> commons-pool > > > >>>> commons-dbcp > > > >>>> etc. > > > >>>> > > > >>>> Currently maven build fails for me (mvn clean package) > > > >>>> with following message: > > > >>>> > > > >>>> [ERROR] Failed to execute goal > > > >>>> org.apache.maven.plugins:maven-antrun-plugin:1.3:run (genmodel) on > > > >>>> project openbooks: An Ant BuildException has occured: The > following > > > >>>> error occurred while executing this line: > > > >>>> [ERROR] > /home/solomax/work/tmp/openjpa/openjpa-examples/openbooks/build.xml:117: > > > >>>> *** Error: > > > >>>> [ERROR] The directory for OpenJPA libraries can not be located > at > > > >>>> > /home/solomax/.m2/repository/org/apache/openjpa/openjpa-all/3.0.1-SNAPSHOT. > > > >>>> [ERROR] Make sure openjpa.lib property value is correct in > > > >>>> build.properties file. > > > >>>> > > > >>>> > > > >>>> What am I doing wrong? > > > >>>> > > > >>>> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; > > > >>>> 2018-02-25T02:49:05+07:00) > > > >>>> Maven home: /opt/maven > > > >>>> Java version: 1.8.0_171, vendor: Oracle Corporation > > > >>>> Java home: /usr/lib/jvm/java-8-oracle/jre > > > >>>> Default locale: en_US, platform encoding: UTF-8 > > > >>>> OS name: "linux", version: "4.4.0-130-generic", arch: "amd64", > family: "unix" > > > >>>> > > > >>>> > > > >>>> -- > > > >>>> WBR > > > >>>> Maxim aka solomax > > > >>> > > > > > > > > > > > > -- > > > > WBR > > > > Maxim aka solomax > > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > -- > WBR > Maxim aka solomax >
