Hi Maxim, I think it would be ok since it is really to enable GC AFAIK.
Side note: did you evaluate dropping commons-collection from the codebase? don't think we abuse of it to justify the dependency. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le mer. 19 sept. 2018 à 06:43, Maxim Solodovnik <[email protected]> a écrit : > Hello All, > > I'm currently working on PR to migrate OpenJpa to latest > commons-collections4 > During this work I noticed commons-collections4 API was changed > > After discussion in commons mailing list [1] I have proposed the PR > [2] to commons collections > During writing the test for this changes I noticed > org.apache.commons.collections4.map.ReferenceMap can be cleaned up and > method purge will not be called ... > > As far as I can understand > org.apache.openjpa.lib.util.ReferenceHashMap was designed to call > keyExpired/valueExpired in case key/value were expired, and these > methods will not be called in case Map will be auto-clean-up by GC. Is > this OK? > > [1] https://markmail.org/thread/tshcd4d54nxrvgbu > [2] https://github.com/apache/commons-collections/pull/51 > > -- > WBR > Maxim aka solomax >
