Yep, same thought No worries, we can always delay a bit the end of the vote to be sure of the quality we deliver
Le lun. 8 avr. 2019 à 23:13, Jonathan Gallimore < [email protected]> a écrit : > At the moment, I believe its a spring-data thing rather than an OpenEJB > thing. I'll try and come up with an actual test, but it'll likely be > tomorrow morning. Hope that's ok. > > Jon > > On Mon, Apr 8, 2019 at 10:08 PM Romain Manni-Bucau <[email protected]> > wrote: > > > IMHO if we break spring data it is a blocker, if we break openejb layer > it > > is not since fixable with the upgrade. > > > > Le lun. 8 avr. 2019 à 23:05, Jonathan Gallimore < > > [email protected]> a écrit : > > > > > Removing the equals() and hashcode() methods added on > > > ParameterExpressionImpl here: > > > > > > > > > https://github.com/apache/openjpa/commit/0e4ec5b392b978c4515b26c60e485f2b610de94f#diff-e357856846fb8b88f15c08e60891cc35 > > > enables > > > the test I mentioned to pass. It seems that _boundsParam.get() here: > > > > > > > > > https://github.com/apache/openjpa/blob/master/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AbstractQuery.java#L81 > > > fails > > > with these equals()/hashcode() methods. > > > > > > Will see if I can fix and send a patch. I'm not sure if this issue > would > > be > > > considered to be a release blocker or not. > > > > > > Jon > > > > > > On Mon, Apr 8, 2019 at 11:25 AM Jonathan Gallimore < > > > [email protected]> wrote: > > > > > > > I get a single test failure on the TomEE side with this release - > > > > specifically org.superbiz.dynamic.DynamicUserDaoTest in > > > > examples/spring-proxy-data. I'll take a look during the day. > Otherwise, > > > > I'm +1. Thanks for the new release! > > > > > > > > Jon > > > > > > > > On Sun, Apr 7, 2019 at 3:14 PM Maxim Solodovnik < > [email protected]> > > > > wrote: > > > > > > > >> +1 > > > >> > > > >> Thanks for this release! > > > >> > > > >> On Sun, 7 Apr 2019 at 17:29, Francesco Chicchiriccò < > > > [email protected]> > > > >> wrote: > > > >> > > > > >> > On 2019-04-06 14:52 Mark Struberg wrote: > > > >> > > hi folks! > > > >> > > > > > >> > > We have fixed tons of enhancements and bugs in OpenJPA for our > > 3.1.0 > > > >> > > release. > > > >> > > One of the main improvements is to move to a native JavaEE8 > level > > - > > > >> > > JPA-2.2. > > > >> > > Please note that we implemented many JPA-2.2 features but not > all > > > yet. > > > >> > > We will work towards implementing the rest of the missing 2.2 > > stuff > > > in > > > >> > > the next bugfix releases. > > > >> > > > > > >> > > > > > >> > > Here are the fixed tickets: > > > >> > > > > > >> > > Sub-task > > > >> > > > > > >> > > • [OPENJPA-2710] - Create and update to > > geronimo-jpa_2.2_spec > > > >> > > Bug > > > >> > > > > > >> > > • [OPENJPA-1993] - Deadlock Potential with ORM XML > > Processing > > > >> > > • [OPENJPA-2555] - Timestamp precision from manual schema > > not > > > >> > > respected > > > >> > > • [OPENJPA-2567] - TINY/MEDIUM/LONG TEXT fields for MySQL > > and > > > >> MariaDB > > > >> > > are not supported > > > >> > > • [OPENJPA-2673] - Table is not created in openjpa > > > >> 3.0.0-SNAPSHOT and > > > >> > > OSGi > > > >> > > • [OPENJPA-2704] - The openjpa.jdbc.Schema no longer > > overrides > > > >> orm.xml > > > >> > > default > > > >> > > • [OPENJPA-2733] - Subquery parameters are incorrectly > > > assigned > > > >> > > • [OPENJPA-2742] - SchemaTool fails with MySQL > > > >> > > • [OPENJPA-2746] - OpenJPA Karaf feature is not complete > > > >> > > • [OPENJPA-2756] - PostgreSQL requires escaping of search > > > >> strings in > > > >> > > all versions > > > >> > > • [OPENJPA-2757] - upgrade to xbean-asm7 to support Java11 > > > >> > > • [OPENJPA-2761] - problem inserting more than 4000 > > charcters > > > in > > > >> > > oracle XMLTYPE column > > > >> > > • [OPENJPA-2764] - Map path expression tests behave random > > > >> > > • [OPENJPA-2768] - XMLStore SAXParser doesn't distinguish > > > >> between > > > >> > > element and extent > > > >> > > • [OPENJPA-2770] - false boolean literal doesn't work > > > >> > > • [OPENJPA-2771] - It seems like h2 'unlimited' is not > > "LIMIT > > > >> 0" but > > > >> > > rather "LIMIT -1" > > > >> > > • [OPENJPA-2772] - list of h2 reserved words is incomplete > > > >> > > • [OPENJPA-2777] - Indices specified using > > > >> javax.persistence.Index > > > >> > > annotation are not being created > > > >> > > • [OPENJPA-2780] - ReverseMappingTool does not generate > > > >> @Enumerated > > > >> > > annotation > > > >> > > • [OPENJPA-2781] - OpenJPA need internet connection to > read > > > the > > > >> > > persistence.xml > > > >> > > Improvement > > > >> > > > > > >> > > • [OPENJPA-2745] - Clean up try-catch implementation for > > > >> DB2Dictionary > > > >> > > • [OPENJPA-2747] - Upgrade to JPA 2.2 and use > > > >> javax.persistence-api > > > >> > > spec > > > >> > > • [OPENJPA-2748] - commons-collections should be updated > to > > > most > > > >> > > recent version > > > >> > > • [OPENJPA-2750] - commons-dbcp need to be updated to most > > > >> recent > > > >> > > version > > > >> > > • [OPENJPA-2751] - Code clean-up should be performed > > > >> > > • [OPENJPA-2752] - More libraries can be updated > > > >> > > • [OPENJPA-2753] - Create profiles to start various > > databases > > > >> via > > > >> > > Docker > > > >> > > • [OPENJPA-2755] - support MySQL DATETIME and TIMESTAMP > > > >> fractions > > > >> > > (milliseconds, nanos) > > > >> > > • [OPENJPA-2773] - set minIdle to > 0 in > > DBCPDriverDataSource > > > >> > > • [OPENJPA-2775] - hsqldb doesn't support NullTable to > > > retrieve > > > >> meta > > > >> > > information > > > >> > > Task > > > >> > > > > > >> > > • [OPENJPA-2744] - commons-pool should be updated to most > > > recent > > > >> > > version > > > >> > > • [OPENJPA-2754] - update to latest dbcp and verify moving > > > from > > > >> > > maxActive to maxTotal > > > >> > > • [OPENJPA-2758] - JPA 2.2 compliance > > > >> > > Dependency upgrade > > > >> > > > > > >> > > • [OPENJPA-2784] - update docs before our release > > > >> > > > > > >> > > > > > >> > > The staging repository is at: > > > >> > > > > > >> > > > > > > https://repository.apache.org/content/repositories/orgapacheopenjpa-1005/ > > > >> > > > > > >> > > The source release is at > > > >> > > > > > >> > > > > > > https://repository.apache.org/content/repositories/orgapacheopenjpa-1005/org/apache/openjpa/openjpa-parent/3.1.0/ > > > >> > > sha1 is 1aea7cfff20c3a5fed57fb41fb1fcd4784b999ae > > > >> > > > > > >> > > I've pushed the release branch to my github repo > > > >> > > https://github.com/struberg/openjpa/tree/release-3.1.0 > > > >> > > > > > >> > > > > > >> > > Please VOTE: > > > >> > > > > > >> > > [+1] yeah, ship it! > > > >> > > [+0] meh, don't care > > > >> > > [-1] nah, because ${showstopper} > > > >> > > > > >> > +1 > > > >> > > > > >> > ..and special thanks to Mark, for his enduring effort! > > > >> > Regards. > > > >> > -- > > > >> > Francesco Chicchiriccò > > > >> > > > > >> > Tirasa - Open Source Excellence > > > >> > http://www.tirasa.net/ > > > >> > > > > >> > Member at The Apache Software Foundation > > > >> > Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail > > > >> > http://home.apache.org/~ilgrosso/ > > > >> > > > >> > > > >> > > > >> -- > > > >> WBR > > > >> Maxim aka solomax > > > >> > > > > > > > > > >
