rmannibucau commented on pull request #37:
URL: https://github.com/apache/openjpa/pull/37#issuecomment-700757319
@mattrpav I'm not speaking of code (so don't look in .java) but of
MANIFEST.MF data. We have an osgi.contract requiring JMS 1 normally. It means
we can work with JMS 1 and 2. What is wrong seems the pom - but your PR does
not change anything at that level. Typically:
javax.jms.*;version="[1.1.0,1.2)"
should now be
javax.jms.*;version="[1.1.0,2.1)"
(tip: for jms 3 it should be rewritten with the shade plugin transformer).
We should probably also ensure we add JMS as an osgi.contract requirement I
think but not in a hurry on this one.
So overall I am -1 to use jms-2 since it will break as explained, +1 to
enable OSGi import to range to v2.1 to enable JMS 2 usage in OSGi.
Hope it makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
