struberg commented on a change in pull request #79:
URL: https://github.com/apache/openjpa/pull/79#discussion_r616123557



##########
File path: 
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/TestUnwrap.java
##########
@@ -30,12 +30,22 @@
 
 import org.apache.openjpa.jdbc.conf.JDBCConfiguration;
 import org.apache.openjpa.jdbc.sql.DerbyDictionary;
+import org.apache.openjpa.jdbc.sql.HerdDBDictionary;
 import org.apache.openjpa.kernel.QueryLanguages;
 import org.apache.openjpa.lib.jdbc.DelegatingConnection;
+import 
org.apache.openjpa.persistence.detachment.model.NoDetachedStateEntityFieldAccess;
+import 
org.apache.openjpa.persistence.detachment.model.NoDetachedStateEntityPropertyAccess;
 import org.apache.openjpa.persistence.test.SingleEMFTestCase;
 
+import static org.junit.Assume.assumeFalse;
+
 public class TestUnwrap extends SingleEMFTestCase {
 
+    @Override
+    protected void setUp(Object... props) {
+        assumeFalse(this.getDBDictionary() instanceof HerdDBDictionary);

Review comment:
       do you just want to skip this test for HerdDB? In which case you can 
simply call `setUnsupportedDatabases(HerdDBDictionary.class)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to