rmannibucau commented on pull request #1: URL: https://github.com/apache/openjpa/pull/1#issuecomment-857562729
Hi @artaxerxe , from what I see I think it still needs some work: 1. fix the formatting issue (imports) 2. ensure org.osgi.core scope is provided (optionally +optional too) since we don't want org.osgi.core in most environments 3. likely add a test ensuring it fixes the issue you mentionned (should be failing today and pass with the patch) 4. wonder if the bundle protocol handling shouldnt be added through a SPI and registered in PersistenceActivator only wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
