rmannibucau commented on pull request #84:
URL: https://github.com/apache/openjpa/pull/84#issuecomment-949311821


   @solomax guess we can add it with exclude(groupid=*, artifactid=*), will fix 
the reactor and have almost no effect on the module itself in test scope.
   
   about 2 I agree with point "a" but this is also an issue if it is explicit 
and code does not prevent it so I dont see why we should priviledge any of 
those. For me it means we should drop the trigger boolean (deprecate) and use 
the setter to align both and warn if both are used with different values. I see 
the "c" but think we should make it consistent cause it is what can hit users, 
in particular when the config is not very clear like that it will likely 
happen, no? Wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to